Skip to content

Commit 1236d1f

Browse files
committed
Strip state down to input + value (the other values never update)
1 parent e6ef290 commit 1236d1f

File tree

1 file changed

+6
-9
lines changed

1 file changed

+6
-9
lines changed

src/ReactCodeInput.js

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class ReactCodeInput extends Component {
3232
constructor(props) {
3333
super(props);
3434

35-
const { fields, isValid, disabled, filterKeyCodes, forceUppercase } = props;
35+
const { fields, forceUppercase } = props;
3636
let { value } = props;
3737

3838
if (forceUppercase) {
@@ -42,9 +42,6 @@ class ReactCodeInput extends Component {
4242
this.state = {
4343
value,
4444
input: [],
45-
isValid,
46-
disabled,
47-
filterKeyCodes,
4845
};
4946

5047
for (let i = 0; i < Number(fields) && i < 32; i += 1) {
@@ -59,9 +56,7 @@ class ReactCodeInput extends Component {
5956

6057
UNSAFE_componentWillReceiveProps(nextProps) {
6158
this.setState({
62-
isValid: nextProps.isValid,
6359
value: nextProps.value,
64-
disabled: nextProps.disabled,
6560
});
6661
}
6762

@@ -153,8 +148,8 @@ class ReactCodeInput extends Component {
153148
let input,
154149
value;
155150

156-
if (this.state.filterKeyCodes.length > 0) {
157-
this.state.filterKeyCodes.some((item) => {
151+
if (this.props.filterKeyCodes.length > 0) {
152+
this.props.filterKeyCodes.some((item) => {
158153
if (item === e.keyCode) {
159154
e.preventDefault();
160155
return true;
@@ -209,17 +204,19 @@ class ReactCodeInput extends Component {
209204
render() {
210205
const {
211206
className,
207+
disabled,
212208
style = {},
213209
inputStyle = {},
214210
inputStyleInvalid = {},
211+
isValid,
215212
type,
216213
autoFocus,
217214
autoComplete,
218215
pattern,
219216
inputMode,
220217
placeholder
221218
} = this.props,
222-
{ disabled, input, isValid } = this.state,
219+
{ input } = this.state,
223220
styles = {
224221
container: { display: 'inline-block', ...style },
225222
input: isValid ? inputStyle : inputStyleInvalid,

0 commit comments

Comments
 (0)