Search experience #2964
Search experience #2964
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
apps/framework-docs-v2/content/moosestack/workflows/trigger-workflow.mdx
Outdated
Show resolved
Hide resolved
apps/framework-docs-v2/content/moosestack/olap/model-materialized-view.mdx
Show resolved
Hide resolved
tg339
force-pushed
the
tim/eng-1190-implement-search-in-docs
branch
from
54fb7a7 to
66ee998
Compare
apps/framework-docs-v2/content/moosestack/streaming/create-stream.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| const displayTitle = title || variantProps.title; | ||
|
|
||
| if (compact) { | ||
| return ( | ||
| <Alert variant={variantProps.variant} className={cn("my-2", className)}> | ||
| {icon && <Icon className="h-4 w-4" />} | ||
| {!href && icon && <Icon className="h-4 w-4" />} | ||
| {href && icon && <Icon className="h-4 w-4 mt-0.5" />} |
There was a problem hiding this comment.
Bug: Falsy Props Break Icon Rendering Conditions
The compact mode renders the icon twice with mutually exclusive conditions checking the icon prop instead of the resolved Icon component. When icon={false}, Icon becomes undefined but these conditions check the original icon prop. This works correctly, but if someone passes a custom component that is falsy (like icon={0} or icon={''} empty string), the condition would fail to render even though a fallback icon exists in the resolved Icon variable. The checks should verify that Icon is defined rather than checking the raw icon prop value.
| OFFSET {offset} | ||
| """ | ||
|
|
||
| results = await client.query.execute(query, params=params_dict) |
There was a problem hiding this comment.
Bug: Parameter Scope Error in Query String
The Python query uses f-string interpolation for {limit} and {offset} on lines 662-663, but these variables aren't defined in the function scope. The code adds limit and offset to params_dict but then tries to reference them as Python variables in the f-string instead of as ClickHouse query parameters. This will cause a NameError at runtime. The {limit} and {offset} should either be parameterized like {limit} in the query string (without f-string interpolation for those placeholders), or the variables need to be extracted from params_dict before the query string is constructed.
| ctaLabel="Details" | ||
| secondaryCtaLink="https://github.com/514-labs/area-code/tree/main/ufa-lite" | ||
| secondaryCtaLabel="Github →" | ||
| badge={{ variant: "default", text: "ClickHouse Cloud demo" }} |
There was a problem hiding this comment.
Bug: CTACard anchor links lead nowhere.
The CTACards have ctaLink values pointing to anchor links like #plane-transponder-demo, #postgres-clickhouse-cdc, #foobar-ufa, and #foobar-ufa-lite, but these corresponding sections with matching IDs don't exist anywhere on the page. When users click the "Details" button, the links won't navigate to any content, resulting in broken navigation. Either the anchor sections need to be added to the page, or the ctaLink props should be removed/changed to external links.
tg339
force-pushed
the
tim/eng-1190-implement-search-in-docs
branch
from
cca5458 to
724133c
Compare
code sizeing new batch data insertion versioning & migration next batch next batch fix mdx-rendered and adding next batch of files adding api files fixed some language rendering and added more pages added workflows files added other workflow files streaming files added additional frameworks added new batch added top level files data modeling all files migrated initial changelog addressing cursor comments fix tabs added a bit of padding to the nav added sonner for language change fix TOC fix the build add ts ignore to mux player removed top nav fix TOC challenges added templates to new docs split server & client components moved to static api route instead we got search udpated errror handling updaign adjusting added default added sitemap update sitemap config caching gh stars fixing issues attempt build fix another attempt at build fix yet another attempt yet another fix yet another centering fixed issues fixed search variety of fixes prevent overscroll fix content wrapper for code editor and consistent heights better search highlights fix alignement of text in sidebar submenu added feature flags add flags wellknown enpoint fixed flags added ai section feature flag made text smalelr in header tiny spacing tweaks fix changelog styles initial guides
tg339
force-pushed
the
tim/eng-1190-implement-search-in-docs
branch
from
724133c to
6b15ce4
Compare
| console.error( | ||
| `Failed to highlight code for language "${language}":`, | ||
| error, | ||
| ); |
There was a problem hiding this comment.
Bug: Debugging Fallback Errors Is Impossible
The error logging in the fallback error handler references the wrong variable. The console.error logs error from the outer catch block instead of fallbackError from the inner catch block, making it impossible to debug failures in the text fallback highlighting.
Note
Introduces feature‑flagged navigation, a Pagefind‑powered command palette, a templates API/grid, extensive new MDX components, and multiple UI/infra refinements across the docs app.
src/app/.well-known/vercel/flags/route.tsand flags (show-hosting-section,show-guides-section,show-ai-section) viasrc/flags.ts.src/app/layout.tsxandsrc/app/page.tsx; pass toTopNavto conditionally show sections.src/app/[...slug]/page.tsx).guidessection and many guide pages (src/config/navigation.ts).src/components/search/command-search.tsx,src/components/ui/command.tsx; wired intoTopNav(⌘/Ctrl+K).src/lib/templates.ts,src/lib/template-types.ts), API endpointsrc/app/api/templates/route.ts, and UI (TemplateCard,TemplateGrid,TemplatesGridServer).MDXRendererwith new components:MuxVideo,FileTree(+ subcomponents), changelog category components,ExportRequirement, tabs/badges,SourceCodeLink, etc.src/components/mdx/*.src/components/scroll-restoration.tsx) and toast system (src/components/ui/sonner.tsx).src/components/navigation/toc-nav.tsx); sidebar/spacing tweaks.src/app/dashboard/page.tsxand old migrate script.Written by Cursor Bugbot for commit 1f7dace. This will update automatically on new commits. Configure here.