Fix Python 3.10+ pipe syntax with create_partial #1537
Closed
+64
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: Jason Liu <jason@jxnl.co>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
instructor | c20d182 | Visit preview | May 16 2025, 10:37 PM |
github-actions
bot
added
bug
Co-Authored-By: Jason Liu <jason@jxnl.co>
|
Closing due to inactivity for more than 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Python 3.10+ pipe syntax with create_partial
Fixes #1523
Description
This PR fixes an issue where using Python 3.10+ pipe syntax for Union types (
str | None) withcreate_partialmethod would crash with a TypeError:type 'types.UnionType' is not subscriptable. After this fix, both syntaxes (Union[str, None]andstr | None) are supported.Changes
_process_generic_argto handletypes.UnionTypefrom Python 3.10+ properly_wrap_modelsto handletypes.UnionTypefrom Python 3.10+ properlyTesting
Added tests that verify the fix works correctly:
tests/dsl/test_union_pipe.py- Tests for_process_generic_argfunctiontests/llm/test_openai/test_pipe_syntax.py- Tests forPartialclass with pipe syntaxLink to Devin run: https://app.devin.ai/sessions/42638ce64e364908a91a6ed24cb022d4
Requested by: Jason Liu (work@jxnl.co)