fix: we weren't linking the dependencies to library target also

Author: kaixoo12

app/CMakeLists.txt

@@ -1,10 +1,6 @@
 message("-- Creating main executable with target name ${CMAKE_PROJECT_NAME}")
 add_executable(${CMAKE_PROJECT_NAME} main.cpp)
 
-message("   finding where Skia shared library is")
-include(FindSkiaSystem)
-message("   set SKIA_LIBRARIES to ${SKIA_LIBRARIES}")
-
 message("-- Use target_link_directories to")
 message("   tell target where to look for .dlls")
 message("   (by default in CMake +3 it is recommended to link by targets, not directories)")

app/main.cpp

@@ -11,7 +11,7 @@ int main(int argc, char *argv[]) {
         std::cout << "- Hello!" << std::endl;
 
         std::cout << "- Initializing GLFW library..." << std::endl;
-        GLUtil::initializeGLFW();
+        initializeGLFW();
 
         std::cout << "- Create blank OpenGL Window" << std::endl;
         std::cout << "  for GPU rendering" << std::endl;

buildscripts/ModuleSetup.cmake

@@ -2,6 +2,8 @@ macro(setup_module name)
         set(MODULE_NAME ${name})
         unset(MODULE_INCLUDES) # module's include paths
         unset(MODULE_FILES) # module's files
+        unset(MODULE_CUSTOM_DIRECTORIES) # custom directories where to look for .so or .a files (DLLs)
+        unset(MODULE_LINK) # module's targets to link against to
 endmacro()
 
 macro(finish_module)
@@ -14,5 +16,15 @@ macro(finish_module)
         message("   with include directories ${MODULE_INCLUDES}")
         include_directories(PRIVATE ${MODULE_INCLUDES})
 
+        if (MODULE_CUSTOM_DIRECTORIES)
+        target_link_directories(${MODULE_NAME} PRIVATE ${MODULE_CUSTOM_DIRECTORIES})
+        message("  find libraries in directories ${MODULE_CUSTOM_DIRECTORIES}")
+        endif()
+
+        if (MODULE_LINK)
+        target_link_libraries(${MODULE_NAME} PRIVATE ${MODULE_LINK})
+        message("  link with libraries ${MODULE_LINK}")
+        endif()
+
 endmacro()
 

src/CMakeLists.txt

@@ -13,4 +13,18 @@ set(MODULE_FILES
     ${CMAKE_SOURCE_DIR}/src/ExampleCanvas.cpp
     )
 
+message("   finding where Skia shared library is")
+include(FindSkiaSystem)
+message("   set SKIA_LIBRARIES to ${SKIA_LIBRARIES}")
+
+set(LIBRARY_DEPENDENCIES
+        ${APP_DEPENDENCIES}
+        ${SKIA_LIBRARIES}
+        glad
+)
+
+set(MODULE_LINK ${LIBRARY_DEPENDENCIES})
+
+set(MODULE_CUSTOM_DIRECTORIES ${CMAKE_BINARY_DIR}/src)
+
 finish_module()

src/GLUtil.cpp

@@ -7,8 +7,6 @@
 // For using OpenGL
 #include <GLFW/glfw3.h>
 
-using namespace GLUtil;
-
 // GLFW is the library which we use to call OpenGL functions
 void initializeGLFW() {
         glfwInit();

src/GLUtil.h

@@ -4,9 +4,6 @@
 
 #pragma once
 
-namespace GLUtil {
-
 void initializeGLFW();
 bool loadGLFunctions();
 
-};

src/GLWindow.cpp

@@ -80,7 +80,7 @@ void GLWindow::createGLWindow() {
 
         // Load GL functions AFTER setting the current context
         // Either we're getting a segmentation fault...
-        GLUtil::loadGLFunctions();
+        loadGLFunctions();
 
         m_glfwWindow = window;
 };