InPlace operations integration request

[N7ghtm4r3]

Hi, using the library I found really useful the appendPageWithUpdates api, but I am asking whether would be possible integrate some wrapper methods to perform a inPlace operations like add, remove, removeAll, addAll, etc using the appendPageWithUpdates api under the hood. If for you is okay this integration I really like create a fork to integrate these inPlace methods. I would use the methods from EquinoxCollectionsUtilitiesKit for the logic to perform that inPlace operations. I have already try to use in my code and works pretty, following there is that snippet:

private fun PaginationState<Int, Product>.retainAndAddInPlace( // will be generic 
    products: Collection<Product>, // will be generic 
    isLastPage: Boolean = false,
) {
    val addAllProducts = allItems.orEmpty().toMutableList()
    addAllProducts.retainAndAdd( // methods from the kit
        supportCollection = products
    )
    appendPageWithUpdates(
        allItems = addAllProducts,
        nextPageKey = requestedPageKey?.plus(1) ?: 0,
        isLastPage = isLastPage
    )
}

[N7ghtm4r3]

Hi, can I integrate these operations?

[Ahmad-Hamwi]

Sorry I do believe the place of such logic is should be outside. It would be great to see something like lazy-pagination-compose-ops for example

[N7ghtm4r3]

Yes great! I understand your point of view, but manage an entire library and keep updated as the original library just for those method is a little be difficult, could be a standalone module inside the library ? The name could be :lazy-pagination-compose-ops like you suggested, but will be directly integrated in the library and will be updated step by step with updates of the core library. Could it be a clean solution to keep what you think?

[N7ghtm4r3]

Hi, just to know this option also is not fit for you?

[Ahmad-Hamwi]

Hey! I believe a separate repository maintained by you would by the optimal way to do it. Thank you for understanding.

[N7ghtm4r3]

Hi, thank you, I'll do it!

[N7ghtm4r3]

Hi, I just want to notify you that the integration has been done as standalone module inside my own library. If you want you can take a look here to read and tell me if there are any issues related to your library. Thank you again!