Skip to content

Commit 112cf5e

Browse files
authored
fix: issue creating transaction not connected to a provider (#2685)
1 parent 2cb4e75 commit 112cf5e

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/ape/api/transactions.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,11 @@ def __init__(self, *args, **kwargs):
7575
@classmethod
7676
def validate_gas_limit(cls, value):
7777
if value is None:
78-
if not cls.network_manager.connected:
79-
raise NetworkError("Must be connected to use default gas config.")
80-
81-
value = cls.network_manager.active_provider.network.gas_limit
78+
value = (
79+
cls.network_manager.active_provider.network.gas_limit
80+
if cls.network_manager.connected
81+
else 0
82+
)
8283

8384
if value == "auto" or isinstance(value, AutoGasLimit):
8485
return None # Delegate to `ProviderAPI.estimate_gas_cost`

tests/functional/test_ecosystem.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -846,6 +846,12 @@ def test_create_transaction_uses_network_gas_limit(tx_type, ethereum, eth_tester
846846
assert tx.gas_limit == eth_tester_provider.max_gas
847847

848848

849+
def test_create_transaction_not_connected(networks_disconnected):
850+
tx = networks_disconnected.ethereum.create_transaction()
851+
# Show it doesn't try to refer to network gas limit.
852+
assert tx.gas_limit == 0
853+
854+
849855
def test_create_transaction_with_none_values(ethereum, eth_tester_provider):
850856
"""
851857
Tests against None being in place of values in kwargs,

0 commit comments

Comments
 (0)