fix: update geth

Author: antazoey

.github/workflows/test.yaml

@@ -87,7 +87,7 @@ jobs:
         - name: Install Geth
           uses: gacts/install-geth-tools@v1
           with:
-            version: 1.15.6
+            version: 1.16.4
 
         - name: Setup Ape
           uses: ApeWorX/github-action@v3

setup.py

@@ -119,7 +119,7 @@
         "eth-typing>=3.5.2,<6",
         "eth-utils>=2.1.0,<6",
         "hexbytes>=1.2.0,<2",
-        "py-geth>=5.4.0,<6",
+        "py-geth>=6.2.0,<7",
         "trie>=3.0.1,<4",  # Peer: stricter pin needed for uv support.
         "web3[tester]>=7.12.1,<8",
         # ** Dependencies maintained by ApeWorX **

src/ape_node/provider.py

@@ -167,7 +167,6 @@ def __init__(
         kwargs_ctor: dict = {
             "data_dir": self.data_dir,
             "geth_executable": executable[0],
-            "network_id": f"{chain_id}",
         }
         if hostname is not None:
             kwargs_ctor["rpc_addr"] = hostname
@@ -199,7 +198,6 @@ def __init__(
         geth_kwargs = construct_test_chain_kwargs(**kwargs_ctor)
         if is_reth:
             geth_kwargs.pop("max_peers", None)
-            geth_kwargs.pop("network_id", None)
             geth_kwargs.pop("no_discover", None)
 
             # NOTE: --verbosity _is_ available in reth, but it is a different type (flag only).
@@ -219,6 +217,10 @@ def __init__(
         self._clean()
 
         geth_kwargs["dev_mode"] = True
+
+        # Does not work with --dev mode.
+        geth_kwargs.pop("network_id", None)
+
         hd_path = hd_path or DEFAULT_TEST_HD_PATH
 
         if generate_accounts:
@@ -243,6 +245,7 @@ def __init__(
         idx = self.command.index(executable[0])
         self.command = self.command[:idx] + executable + self.command[idx + 1 :]
 
+
     @classmethod
     def from_uri(cls, uri: str, data_folder: Path, **kwargs):
         mnemonic = kwargs.get("mnemonic", DEFAULT_TEST_MNEMONIC)