Skip to content

fix: handle geth 1.16.3 for dev node #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: handle geth 1.16.3 for dev node #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f934f5
fix: update geth
antazoey Sep 29, 2025
7d06fab
chore: fmt
antazoey Sep 29, 2025
5a243ba
fix: try point three
antazoey Sep 29, 2025
353de87
fix: try less ver
antazoey Sep 29, 2025
c044d5b
Merge branch 'main' into fix/geth
fubuloubu Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
- name: Install Geth
uses: gacts/install-geth-tools@v1
with:
version: 1.15.6
version: 1.16.2

- name: Setup Ape
uses: ApeWorX/github-action@v3
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
"eth-typing>=3.5.2,<6",
"eth-utils>=2.1.0,<6",
"hexbytes>=1.2.0,<2",
"py-geth>=5.4.0,<6",
"py-geth>=6.2.0,<7",
"trie>=3.0.1,<4", # Peer: stricter pin needed for uv support.
"web3[tester]>=7.12.1,<8",
# ** Dependencies maintained by ApeWorX **
Expand Down
6 changes: 4 additions & 2 deletions src/ape_node/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ def __init__(
kwargs_ctor: dict = {
"data_dir": self.data_dir,
"geth_executable": executable[0],
"network_id": f"{chain_id}",
}
if hostname is not None:
kwargs_ctor["rpc_addr"] = hostname
Expand Down Expand Up @@ -199,7 +198,6 @@ def __init__(
geth_kwargs = construct_test_chain_kwargs(**kwargs_ctor)
if is_reth:
geth_kwargs.pop("max_peers", None)
geth_kwargs.pop("network_id", None)
geth_kwargs.pop("no_discover", None)

# NOTE: --verbosity _is_ available in reth, but it is a different type (flag only).
Expand All @@ -219,6 +217,10 @@ def __init__(
self._clean()

geth_kwargs["dev_mode"] = True

# Does not work with --dev mode.
geth_kwargs.pop("network_id", None)

hd_path = hd_path or DEFAULT_TEST_HD_PATH

if generate_accounts:
Expand Down
Loading