Skip to content

Commit 655d44a

Browse files
authored
Merge pull request #629 from Automattic/fix/ci-failures
CI: fix build failures
2 parents a58e583 + 87ddd1b commit 655d44a

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

WordPress-VIP-Go/ruleset-test.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ function foo_bar_bar() {
214214

215215
// VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
216216
function foo_bar_foo() {
217-
$a = 'Hello'; // Warning
217+
$a = 'Hello'; // OK. Unused variables warning silenced.
218218
}
219219

220220
// WordPressVIPMinimum.UserExperience.AdminBarRemoval
@@ -417,7 +417,7 @@ the_sub_field( 'field' ); // Warning.
417417
the_field( 'field' ); // Warning.
418418
wp_remote_get( $url ); // Warning.
419419
get_posts(); // Warning.
420-
function test_function( $a, $b ) {
420+
function test_function( $a, $b ) { // OK. Unused variables warning silenced.
421421
return create_function( '$a, $b', 'return ( $b / $a ); '); // Warning.
422422
}
423423
wpcom_vip_get_term_link(); // Warning.

WordPress-VIP-Go/ruleset-test.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,6 @@
184184
207 => 1,
185185
208 => 1,
186186
212 => 1,
187-
217 => 1,
188187
221 => 1,
189188
223 => 1,
190189
225 => 1,
@@ -222,7 +221,6 @@
222221
417 => 1,
223222
418 => 1,
224223
419 => 1,
225-
420 => 2,
226224
421 => 1,
227225
423 => 1,
228226
424 => 1,

WordPressVIPMinimum/ruleset-test.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@
164164
393 => 1,
165165
394 => 1,
166166
395 => 1,
167+
402 => 1,
167168
415 => 1,
168169
425 => 1,
169170
451 => 1,
@@ -269,7 +270,6 @@
269270
399 => 1,
270271
400 => 1,
271272
401 => 1,
272-
402 => 1,
273273
403 => 1,
274274
404 => 1,
275275
405 => 1,

0 commit comments

Comments
 (0)