Remove no-longer-needed Squiz.PHP.InnerFunctions.NotAllowed ignores. Seems the new rule is ok with function→class→function.

Author: anomiex

projects/packages/classic-theme-helper/changelog/update-codesniffer-rulesets

@@ -1,5 +1,5 @@
 Significance: patch
 Type: changed
-Comment: Replace `MediaWiki.Usage.NestedFunctions` with `Squiz.PHP.InnerFunctions`.
+Comment: Remove `MediaWiki.Usage.NestedFunctions`,  `Squiz.PHP.InnerFunctions` is ok with function→class→function.
 
 

projects/packages/classic-theme-helper/src/content-options/customizer.php

@@ -74,7 +74,7 @@ class Jetpack_Customize_Control_Title extends WP_Customize_Control {
 				/**
 				 * Render the control's content.
 				 */
-				public function render_content() { // phpcs:ignore Squiz.PHP.InnerFunctions.NotAllowed
+				public function render_content() {
 					?>
 					<span class="customize-control-title"><?php echo wp_kses_post( $this->label ); ?></span>
 					<?php

projects/packages/jetpack-mu-wpcom/changelog/update-codesniffer-rulesets

@@ -1,5 +1,5 @@
 Significance: patch
 Type: changed
-Comment: Replace `MediaWiki.Usage.NestedFunctions` with `Squiz.PHP.InnerFunctions`.
+Comment: Replace `MediaWiki.Usage.NestedFunctions` with `Squiz.PHP.InnerFunctions`. Remove some where `Squiz.PHP.InnerFunctions` is ok with function→class→function.
 
 

projects/packages/jetpack-mu-wpcom/src/features/custom-css/custom-css.php

@@ -1228,7 +1228,7 @@ class safecss extends csstidy_optimise { // phpcs:ignore
 			/**
 			 * Optimises $css after parsing.
 			 */
-			public function postparse() { // phpcs:ignore Squiz.PHP.InnerFunctions.NotAllowed
+			public function postparse() {
 
 				/** This action is documented in modules/custom-css/custom-css.php */
 				do_action( 'csstidy_optimize_postparse', $this );
@@ -1239,7 +1239,7 @@ public function postparse() { // phpcs:ignore Squiz.PHP.InnerFunctions.NotAllowe
 			/**
 			 * Optimises a sub-value.
 			 */
-			public function subvalue() { // phpcs:ignore Squiz.PHP.InnerFunctions.NotAllowed
+			public function subvalue() {
 
 				/** This action is documented in modules/custom-css/custom-css.php */
 				do_action( 'csstidy_optimize_subvalue', $this );

projects/plugins/jetpack/changelog/update-codesniffer-rulesets

@@ -1,5 +1,5 @@
 Significance: patch
 Type: other
-Comment: Replace `MediaWiki.Usage.NestedFunctions` with `Squiz.PHP.InnerFunctions`.
+Comment: Replace `MediaWiki.Usage.NestedFunctions` with `Squiz.PHP.InnerFunctions`. Remove some where `Squiz.PHP.InnerFunctions` is ok with function→class→function.
 
 

projects/plugins/jetpack/modules/custom-post-types/testimonial.php

@@ -5,7 +5,6 @@
  * @package automattic/jetpack
  *
  * @phpcs:disable Generic.Files.OneObjectStructurePerFile.MultipleFound
- * @phpcs:disable Squiz.PHP.InnerFunctions.NotAllowed
  */
 
 // phpcs:disable Universal.Files.SeparateFunctionsFromOO.Mixed -- TODO: Move classes to appropriately-named class files.

projects/plugins/jetpack/modules/theme-tools/content-options/customizer.php

@@ -75,7 +75,7 @@ class Jetpack_Customize_Control_Title extends WP_Customize_Control {
 				/**
 				 * Render the control's content.
 				 */
-				public function render_content() { // phpcs:ignore Squiz.PHP.InnerFunctions.NotAllowed
+				public function render_content() {
 					?>
 					<span class="customize-control-title"><?php echo wp_kses_post( $this->label ); ?></span>
 					<?php

projects/plugins/wpcomsh/changelog/update-codesniffer-rulesets

@@ -1,5 +1,5 @@
 Significance: patch
 Type: changed
-Comment: Replace `MediaWiki.Usage.NestedFunctions` with `Squiz.PHP.InnerFunctions`.
+Comment: Remove `MediaWiki.Usage.NestedFunctions`,  `Squiz.PHP.InnerFunctions` is ok with function→class→function.
 
 

projects/plugins/wpcomsh/footer-credit/footer-credit/customizer.php

@@ -33,7 +33,7 @@ class WP_Customize_Footercredit_Select extends WP_Customize_Control {
 		/**
 		 * Enqueue scripts and styles.
 		 */
-		public function enqueue() { // phpcs:ignore Squiz.PHP.InnerFunctions.NotAllowed
+		public function enqueue() {
 			if ( ! apply_filters( 'wpcom_better_footer_credit_can_customize', true ) ) {
 				wp_enqueue_script( 'footercredit-control', plugins_url( 'js/control.js', __FILE__ ), array( 'jquery' ), WPCOMSH_VERSION, true );
 				wp_enqueue_style( 'footercredit-control-styles', plugins_url( 'css/control.css', __FILE__ ), array(), WPCOMSH_VERSION );
@@ -43,7 +43,7 @@ public function enqueue() { // phpcs:ignore Squiz.PHP.InnerFunctions.NotAllowed
 		/**
 		 * Render Footer Credits settings in Customizer.
 		 */
-		public function render_content() { // phpcs:ignore Squiz.PHP.InnerFunctions.NotAllowed
+		public function render_content() {
 			?>
 			<label>
 				<?php if ( ! empty( $this->label ) ) : ?>