-
Notifications
You must be signed in to change notification settings - Fork 841
Forms: fix staged changes sync #45854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
e344d8d to
f47a06f
Compare
Proposed changes:
This PR is a WIP while looking for better options. It calls saveEditedEntityRecord (after the record has been edited) with
__unstableFetchoption to use the custom API endpoint for read/unread status toggle.This way, the edit done when toggling read/unread status is immediately "committed" to store and fetches from the API.
Other information:
Jetpack product discussion
p1762795602061299/1762781493.442119-slack-C052XEUUBL4
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Test on all envs by confirming toggling read/unread continues to work. See that no staged changes are out of sync on the store.