Skip to content

Forms: fix staged changes sync #45854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Forms: fix staged changes sync #45854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8442938
changelog
CGastrell Nov 10, 2025
f47a06f
replace apiFetch for action using unstable fetch mechanic
CGastrell Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/forms/changelog/fix-forms-staged-changes-sync
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Forms: toggling read/unread currently leaves dirty records, fix depends on core store unstable mechanics
14 changes: 9 additions & 5 deletions projects/packages/forms/src/dashboard/components/response-view/body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ const ResponseViewBody = ( {
const [ isImageLoading, setIsImageLoading ] = useState( true );
const [ hasMarkedSelfAsRead, setHasMarkedSelfAsRead ] = useState( 0 );

const { editEntityRecord } = useDispatch( 'core' );
const { editEntityRecord, saveEditedEntityRecord } = useDispatch( 'core' );

const emptyTrashDays = useConfigValue( 'emptyTrashDays' ) ?? 0;

Expand Down Expand Up @@ -376,10 +376,13 @@ const ResponseViewBody = ( {
}

// Then update on server
apiFetch( {
path: `/wp/v2/feedback/${ response.id }/read`,
method: 'POST',
data: { is_unread: false },
saveEditedEntityRecord( 'postType', 'feedback', response.id, {
__unstableFetch: () =>
apiFetch( {
path: `/wp/v2/feedback/${ response.id }/read`,
method: 'POST',
data: { is_unread: false },
} ),
} )
.then( ( { count }: { count: number } ) => {
// Update menu counter with accurate count from server
Expand Down Expand Up @@ -407,6 +410,7 @@ const ResponseViewBody = ( {
invalidateCounts,
markRecordsAsInvalid,
currentQuery,
saveEditedEntityRecord,
] );

const handelImageLoaded = useCallback( () => {
Expand Down
15 changes: 9 additions & 6 deletions projects/packages/forms/src/dashboard/inbox/dataviews/actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ export const markAsReadAction: Action = {
multiple: items.length > 1,
} );

const { editEntityRecord } = registry.dispatch( coreStore );
const { editEntityRecord, saveEditedEntityRecord } = registry.dispatch( coreStore );
const { getEntityRecord } = registry.select( coreStore );
const { createSuccessNotice, createErrorNotice } = registry.dispatch( noticesStore );
const { invalidateCounts, markRecordsAsInvalid } = registry.dispatch( dashboardStore );
Expand All @@ -592,12 +592,15 @@ export const markAsReadAction: Action = {
}

// Update on server
return apiFetch( {
path: `/wp/v2/feedback/${ id }/read`,
method: 'POST',
data: { is_unread: false },
return saveEditedEntityRecord( 'postType', 'feedback', id, {
__unstableFetch: () =>
apiFetch( {
path: `/wp/v2/feedback/${ id }/read`,
method: 'POST',
data: { is_unread: false },
} ),
} )
.then( ( { count } ) => {
.then( ( { count }: { count: number } ) => {
// Update menu counter with accurate count from server.
updateMenuCounter( count );
} )
Expand Down
6 changes: 6 additions & 0 deletions projects/packages/forms/src/dashboard/inbox/dataviews/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ export type Registry = {
name: string,
record: Record< string, unknown >
) => Promise< void >;
saveEditedEntityRecord: (
kind: string,
name: string,
recordId: number,
options?: { __unstableFetch?: () => Promise< void > }
) => Promise< { id: string; count: number } >;
deleteEntityRecord: (
kind: string,
name: string,
Expand Down
Loading