Skip to content

Conversation

@salma-elshafey
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copilot AI review requested due to automatic review settings November 10, 2025 12:58
@salma-elshafey salma-elshafey requested a review from a team as a code owner November 10, 2025 12:58
@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Nov 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds input validation to ensure that the query parameter is required and cannot be None in three tool evaluators: Tool Selection, Tool Input Accuracy, and Tool Call Accuracy. This improves error handling by providing clear error messages when users attempt to call these evaluators without the required query parameter.

  • Adds query parameter validation in the _do_eval methods of three evaluators
  • Raises EvaluationException with descriptive messages when query is missing or None
  • Adds comprehensive unit tests to verify the validation behavior in both scenarios (query=None and query not provided)

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_tool_selection/_tool_selection.py Adds query validation to Tool Selection evaluator
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_tool_input_accuracy/_tool_input_accuracy.py Adds query validation to Tool Input Accuracy evaluator
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_tool_call_accuracy/_tool_call_accuracy.py Adds query validation to Tool Call Accuracy evaluator
sdk/evaluation/azure-ai-evaluation/tests/unittests/test_tool_selection_evaluator.py Adds test cases for query validation in Tool Selection evaluator
sdk/evaluation/azure-ai-evaluation/tests/unittests/test_tool_input_accuracy_evaluator.py Adds test cases for query validation in Tool Input Accuracy evaluator
sdk/evaluation/azure-ai-evaluation/tests/unittests/test_tool_call_accuracy_evaluator.py Adds test cases for query validation in Tool Call Accuracy evaluator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Evaluation Issues related to the client library for Azure AI Evaluation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants