Skip to content

Commit 4eb9169

Browse files
authored
SWI-8362 Fix tracks Capitalization for StartStream (#196)
1 parent 935ee19 commit 4eb9169

File tree

3 files changed

+22
-6
lines changed

3 files changed

+22
-6
lines changed

src/main/java/com/bandwidth/sdk/model/bxml/StartStream.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@
1313
import jakarta.xml.bind.annotation.XmlElements;
1414
import jakarta.xml.bind.annotation.XmlType;
1515
import java.util.List;
16-
import java.util.UUID;
1716

18-
import com.bandwidth.sdk.model.CallDirectionEnum;
1917

2018
import lombok.AllArgsConstructor;
2119
import lombok.Builder;
@@ -84,7 +82,7 @@ public class StartStream implements Verb {
8482

8583
@XmlAttribute
8684
@Default
87-
protected CallDirectionEnum tracks = CallDirectionEnum.INBOUND;
85+
protected TracksEnum tracks = TracksEnum.inbound;
8886

8987
@XmlAttribute
9088
protected String destination;
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package com.bandwidth.sdk.model.bxml;
2+
3+
public enum TracksEnum {
4+
5+
inbound("inbound"),
6+
7+
outbound("outbound");
8+
9+
private String value;
10+
11+
TracksEnum(String value) {
12+
this.value = value;
13+
}
14+
15+
public String getValue() {
16+
return value;
17+
}
18+
}

src/test/java/com/bandwidth/sdk/unit/models/bxml/StartStreamVerbTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88

99
package com.bandwidth.sdk.unit.models.bxml;
1010

11-
import com.bandwidth.sdk.model.CallDirectionEnum;
1211
import com.bandwidth.sdk.model.bxml.Bxml;
1312
import com.bandwidth.sdk.model.bxml.StartStream;
1413
import com.bandwidth.sdk.model.bxml.StreamParam;
14+
import com.bandwidth.sdk.model.bxml.TracksEnum;
1515

1616
import jakarta.xml.bind.JAXBContext;
1717
import jakarta.xml.bind.JAXBException;
@@ -38,7 +38,7 @@ public class StartStreamVerbTest {
3838
StartStream startStream = StartStream.builder()
3939
.name("stream1")
4040
.mode("unidirectional")
41-
.tracks(CallDirectionEnum.INBOUND)
41+
.tracks(TracksEnum.inbound)
4242
.destination("testurl.com")
4343
.streamEventUrl("eventurl.com")
4444
.streamEventMethod("POST")
@@ -50,7 +50,7 @@ public class StartStreamVerbTest {
5050
@Test
5151
public void startStreamVerbWorks() throws JAXBException {
5252
JAXBContext jaxbContext = JAXBContext.newInstance(Bxml.class);
53-
String expectedBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><StartStream name=\"stream1\" mode=\"unidirectional\" tracks=\"INBOUND\" destination=\"testurl.com\" streamEventUrl=\"eventurl.com\" streamEventMethod=\"POST\" username=\"user\" password=\"pass\"><StreamParam name=\"name1\" value=\"value1\"/><StreamParam name=\"name2\" value=\"value2\"/></StartStream></Bxml>";
53+
String expectedBxml = "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?><Bxml><StartStream name=\"stream1\" mode=\"unidirectional\" tracks=\"inbound\" destination=\"testurl.com\" streamEventUrl=\"eventurl.com\" streamEventMethod=\"POST\" username=\"user\" password=\"pass\"><StreamParam name=\"name1\" value=\"value1\"/><StreamParam name=\"name2\" value=\"value2\"/></StartStream></Bxml>";
5454

5555
assertThat(new Bxml().with(startStream).toBxml(jaxbContext), is(expectedBxml));
5656
}

0 commit comments

Comments
 (0)