-
-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Labels
Description
Hi BioAlignments,
Just wanted to put in a friendly request for API changes to follow Julia's @deprecate pattern for API changes please, so for example in package v0.1.x:
# src/AwesomeCode.jl
oldsignature(x::Int) = # does thingThen the API change goes into v0.2.0 along with the deprecation
# src/AwesomeCode.jl
newsignature(x::Float64) = # does similar thing
# src/Deprecated.jl
@deprecate oldsignature(x::Int) newsignature(float(x))This will give users a chance to update their scripts with a useful auto-generated warning, which tells them how to replace old calls with new ones.
Then remove the deprecation in v0.3
# src/AwesomeCode.jl
newsignature(x::Float64) = # does similar thingAlso consider listing breaking changes in a NEWS.md. Based on a quick search it looks like the @deprecate feature is not used here much.
Thanks for the great package!