Skip to content

Commit 06052ff

Browse files
committed
qt: fix Wayland also for AppImage
Same as 5655e63, but the excluded libwayland-client.so.0 made its way back in the second call to linuxdeployqt, so the issue fixed in the original commit was still present when using the AppImage.
1 parent 29aa8cb commit 06052ff

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## Unreleased
44

5+
## v4.48.3
6+
- Linux: fix compatiblity with some versions of Mesa also when using the AppImage
7+
58
## v4.48.2
69
- iOS: Fix blank screens after prolonged inactivity
710

backend/update.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const updateFileURL = "https://bitboxapp.shiftcrypto.io/desktop.json"
2727

2828
var (
2929
// Version of the backend as displayed to the user.
30-
Version = semver.NewSemVer(4, 48, 2)
30+
Version = semver.NewSemVer(4, 48, 3)
3131
)
3232

3333
// UpdateFile is retrieved from the server.

frontends/qt/Makefile

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,15 @@
1414

1515
include ../../env.mk.inc
1616

17+
# Add Wayland libs so the app can run natively on Wayland too.
18+
# The linuxdeployqt maintainer unfortunately refuses to support it automatically: https://github.com/probonopd/linuxdeployqt/issues/189
19+
# The list of related plugins was found by: `find $(qmake -query QT_INSTALL_PLUGINS) | grep wayland`
20+
#
21+
# Exclude libwayland-client.so.0, see https://github.com/AppImageCommunity/pkg2appimage/commit/15a64c20dc23a0154622ba25829364323903b6b5,
22+
# but that is yet in the default exclusion lib of linuxdeployqt.
23+
# See also: https://github.com/probonopd/linuxdeployqt/issues/631 - we can remove the libwayland-client.so.0 exclusion once this is merged and we updated our linuxdeployqt binary.
24+
EXCLUDE_LIBS:=libwayland-client.so.0
25+
1726
base:
1827
mkdir build
1928
./genassets.sh
@@ -30,20 +39,13 @@ linux:
3039
mv build/BitBox build/linux-tmp
3140
cp build/assets.rcc build/linux-tmp/
3241
cp server/libserver.so build/linux-tmp
33-
# Add Wayland libs so the app can run natively on Wayland too.
34-
# The linuxdeployqt maintainer unfortunately refuses to support it automatically: https://github.com/probonopd/linuxdeployqt/issues/189
35-
# The list of related plugins was found by: `find $(qmake -query QT_INSTALL_PLUGINS) | grep wayland`
36-
#
37-
# Exclude libwayland-client.so.0, see https://github.com/AppImageCommunity/pkg2appimage/commit/15a64c20dc23a0154622ba25829364323903b6b5,
38-
# but that is yet in the default exclusion lib of linuxdeployqt.
39-
# See also: https://github.com/probonopd/linuxdeployqt/issues/631 - we can remove the libwayland-client.so.0 exclusion once this is merged and we updated our linuxdeployqt binary.
4042
cd build/linux-tmp && \
4143
/opt/linuxdeployqt-continuous-x86_64.AppImage --appimage-extract && \
4244
./squashfs-root/AppRun BitBox \
4345
-bundle-non-qt-libs \
4446
-unsupported-allow-new-glibc \
4547
-extra-plugins=platforms/libqwayland-generic.so,platforms/libqwayland-egl.so,wayland-graphics-integration-client,wayland-decoration-client,wayland-shell-integration \
46-
-exclude-libs=libwayland-client.so.0
48+
-exclude-libs=$(EXCLUDE_LIBS)
4749
cp /usr/lib/x86_64-linux-gnu/nss/* build/linux-tmp/lib
4850
# See https://github.com/probonopd/linuxdeployqt/issues/554#issuecomment-1761834180
4951
cp "$(shell qmake -query QT_INSTALL_DATA)/resources/v8_context_snapshot.bin" build/linux-tmp/resources
@@ -58,7 +60,8 @@ linux:
5860
cd build/linux-tmp && \
5961
./squashfs-root/AppRun BitBox \
6062
-appimage \
61-
-unsupported-allow-new-glibc
63+
-unsupported-allow-new-glibc \
64+
-exclude-libs=$(EXCLUDE_LIBS)
6265
mv build/linux-tmp/BitBoxApp*-x86_64.AppImage build/linux/
6366
osx:
6467
$(MAKE) clean

0 commit comments

Comments
 (0)