Skip to content

Commit daaf231

Browse files
committed
qt: go back to software rendering
We attempted to use GPU accelerated rendering in a9823e9. Some users had rendering artefacts on Windows, and at least one user could not launch the app on Ubuntu 18.04 with: ``` ERROR:command_buffer_proxy_lmpl.cc Context Result::KTranslentFailure:Failed to send GpuChannelMsg_ CreateCommandBuffer. Segmentation fault (core dumped) ``` To fix these issues, we revert the change and re-enable software rendering. We also tried the RHI (QSG_RHI=1 env var), but that does not work (rendes only a black screen) with QtWebengine due to this bug: https://bugreports.qt.io/browse/QTBUG-78682 (fix expected only in Qt6.1, with QtWebengine not being available until Qt6.2) GPU acceleration was enabled to deal with a very laggy animation when opening dialogs on Windows. We will deal with this by disabling such animations in another commit.
1 parent 47179c2 commit daaf231

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
## [Unreleased]
44
- Verify the EIP-55 checksum in mixed-case Ethereum recipient addresses
5+
- Disable GPU acceleration introduced in v4.29.0 due to rendering artefacts on Windows
56

67
## 4.29.0 [released 2021-08-03]
78
- Add support for the Address Ownership Proof Protocol (AOPP), i.e.: handle 'aopp:?...' URIs. See https://aopp.group/.
@@ -13,6 +14,7 @@
1314
- Prevent screen from turning off while the app is in foreground on Android
1415
- Allow entering the BitBox02 startup settings in 'Manage device' to toggle showing the firmware hash at any time
1516
- More user-friendly messages for first BitBox02 firmware install
17+
- Use hardware accelerated rendering in Qt if available
1618

1719
## 4.28.2 [released 2021-06-03]
1820
- Fix a conversion rates updater bug

frontends/qt/main.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,11 @@ int main(int argc, char *argv[])
163163
qputenv("DRAW_USE_LLVM", "0");
164164
#endif
165165

166+
// Force software rendering over GPU-accelerated rendering as various rendering artefact issues
167+
// were observed on Windows and the app crashes on some Linux systems.
168+
qputenv("QMLSCENE_DEVICE", "softwarecontext");
169+
qputenv("QT_QUICK_BACKEND", "software");
170+
166171

167172
BitBoxApp a(argc, argv);
168173
// These three are part of the SingleApplication instance ID - if changed, the user should close

0 commit comments

Comments
 (0)