[site] Update redirect

Author: Breakthrough

scenedetect/common.py

@@ -139,6 +139,11 @@ class Timecode:
     """Presentation timestamp of the frame in units of `time_base`."""
     time_base: Fraction
     """The base unit in which `pts` is measured."""
+    #
+    # TODO(0.7): We Let's require a frame number to be specified here. It's cheap to calculate
+    # and store, avoids breaking too much, and allows us to pass that through in FrameTimecode
+    # where a frame number/index is required.
+    #
 
     @property
     def seconds(self) -> float:

tests/test_cli.py

@@ -103,7 +103,7 @@ def invoke_scenedetect(
     if config_file:
         command += " -c %s" % config_file
     command += " " + args.format(**value_dict)
-    return subprocess.call(command.strip().split(" "))
+    return subprocess.call(command.strip().split(" "), shell=True)
 
 
 def test_cli_no_args():
@@ -172,6 +172,7 @@ def test_cli_time_end():
             + ["-i", DEFAULT_VIDEO_PATH, "-m", "0", "detect-content", "list-scenes", "-n"]
             + test_case.split(),
             text=True,
+            shell=True,
         )
         assert EXPECTED in output, test_case
 
@@ -200,6 +201,7 @@ def test_cli_time_start():
             + ["-i", DEFAULT_VIDEO_PATH, "-m", "0", "detect-content", "list-scenes", "-n"]
             + test_case.split(),
             text=True,
+            shell=True,
         )
         assert EXPECTED in output, test_case
 
@@ -245,6 +247,7 @@ def test_cli_time_scene_boundary():
             + ["-i", DEFAULT_VIDEO_PATH, "-m", "0", "detect-content", "list-scenes", "-n"]
             + test_case.split(),
             text=True,
+            shell=True,
         )
         assert EXPECTED in output, test_case
 
@@ -256,6 +259,7 @@ def test_cli_time_end_of_video():
         SCENEDETECT_CMD.split(" ")
         + ["-i", DEFAULT_VIDEO_PATH, "detect-content", "list-scenes", "-n", "time", "-s", "1872"],
         text=True,
+        shell=True,
     )
     assert (
         """
@@ -408,7 +412,13 @@ def test_cli_split_video_ffmpeg(tmp_path: Path):
         " "
     )
     command.append(DEFAULT_FFMPEG_ARGS)
-    assert subprocess.call(command) == 0
+    assert (
+        subprocess.call(
+            command,
+            shell=True,
+        )
+        == 0
+    )
     entries = sorted(tmp_path.glob(f"{DEFAULT_VIDEO_NAME}-Scene-*"))
     assert len(entries) == DEFAULT_NUM_SCENES, entries
     [entry.unlink() for entry in entries]
@@ -424,7 +434,13 @@ def test_cli_split_video_ffmpeg(tmp_path: Path):
     [entry.unlink() for entry in entries]
 
     command += ["-f", "abc$VIDEO_NAME-123$SCENE_NUMBER"]
-    assert subprocess.call(command) == 0
+    assert (
+        subprocess.call(
+            command,
+            shell=True,
+        )
+        == 0
+    )
     entries = sorted(tmp_path.glob(f"abc{DEFAULT_VIDEO_NAME}-123*"))
     assert len(entries) == DEFAULT_NUM_SCENES, entries
     [entry.unlink() for entry in entries]
@@ -673,6 +689,7 @@ def test_cli_load_scenes_with_time_frames():
             "list-scenes",
         ],
         text=True,
+        shell=True,
     )
     assert (
         """
@@ -715,6 +732,7 @@ def test_cli_load_scenes_round_trip():
             "400",
         ],
         text=True,
+        shell=True,
     )
     loaded_first_pass = subprocess.check_output(
         SCENEDETECT_CMD.split(" ")
@@ -734,6 +752,7 @@ def test_cli_load_scenes_round_trip():
             "testout2.csv",
         ],
         text=True,
+        shell=True,
     )
     SPLIT_POINT = " | Scene # | Start Frame |  Start Time  |  End Frame  |   End Time   |"
     assert ground_truth.split(SPLIT_POINT)[1] == loaded_first_pass.split(SPLIT_POINT)[1]