feat(formats): rename 'CartridgeOfLife' by 'SafetyCartridge'

Author: CarlosPavajeau

src/Armory.Api/Controllers/Formats/AssignedWeaponMagazineFormats/Requests/AddAssignedWeaponMagazineFormatItemRequest.cs

@@ -5,7 +5,7 @@ public class AddAssignedWeaponMagazineFormatItemRequest
         public int FormatId { get; set; }
         public string TroopId { get; set; }
         public string WeaponCode { get; set; }
-        public bool CartridgeOfLife { get; set; }
+        public bool SafetyCartridge { get; set; }
         public bool VerifiedInPhysical { get; set; }
         public bool Novelty { get; set; }
         public int AmmunitionQuantity { get; set; }

src/Armory/Formats/AssignedWeaponMagazineFormats/Application/AddItem/AddAssignedWeaponMagazineFormatItemCommand.cs

@@ -5,13 +5,13 @@ namespace Armory.Formats.AssignedWeaponMagazineFormats.Application.AddItem
     public class AddAssignedWeaponMagazineFormatItemCommand : Command<AssignedWeaponMagazineFormatItemResponse>
     {
         public AddAssignedWeaponMagazineFormatItemCommand(int formatId, string troopId, string weaponCode,
-            bool cartridgeOfLife, bool verifiedInPhysical, bool novelty, int ammunitionQuantity, string ammunitionLot,
+            bool safetyCartridge, bool verifiedInPhysical, bool novelty, int ammunitionQuantity, string ammunitionLot,
             string observations)
         {
             FormatId = formatId;
             TroopId = troopId;
             WeaponCode = weaponCode;
-            CartridgeOfLife = cartridgeOfLife;
+            SafetyCartridge = safetyCartridge;
             VerifiedInPhysical = verifiedInPhysical;
             Novelty = novelty;
             AmmunitionQuantity = ammunitionQuantity;
@@ -22,7 +22,7 @@ public AddAssignedWeaponMagazineFormatItemCommand(int formatId, string troopId,
         public int FormatId { get; }
         public string TroopId { get; }
         public string WeaponCode { get; }
-        public bool CartridgeOfLife { get; }
+        public bool SafetyCartridge { get; }
         public bool VerifiedInPhysical { get; }
         public bool Novelty { get; }
         public int AmmunitionQuantity { get; }

src/Armory/Formats/AssignedWeaponMagazineFormats/Application/AddItem/AddAssignedWeaponMagazineFormatItemCommandHandler.cs

@@ -27,7 +27,7 @@ public async Task<AssignedWeaponMagazineFormatItemResponse> Handle(
                 request.FormatId,
                 request.TroopId,
                 request.WeaponCode,
-                request.CartridgeOfLife,
+                request.SafetyCartridge,
                 request.VerifiedInPhysical,
                 request.Novelty,
                 request.AmmunitionQuantity,

src/Armory/Formats/AssignedWeaponMagazineFormats/Application/AddItem/AssignedWeaponMagazineFormatItemAdder.cs

@@ -18,7 +18,7 @@ public AssignedWeaponMagazineFormatItemAdder(IAssignedWeaponMagazineFormatsRepos
         }
 
         public async Task<AssignedWeaponMagazineFormatItem> AddItem(int formatId, string troopId, string weaponCode,
-            bool cartridgeOfLife,
+            bool safetyCartridge,
             bool verifiedInPhysical, bool novelty, int ammunitionQuantity, string ammunitionLot, string observations)
         {
             var format = await _repository.Find(formatId, false);
@@ -27,7 +27,7 @@ public async Task<AssignedWeaponMagazineFormatItem> AddItem(int formatId, string
                 throw new AssignedWeaponMagazineFormatNotFound();
             }
 
-            format.Records.Add(AssignedWeaponMagazineFormatItem.Create(troopId, weaponCode, cartridgeOfLife,
+            format.Records.Add(AssignedWeaponMagazineFormatItem.Create(troopId, weaponCode, safetyCartridge,
                 verifiedInPhysical, novelty, ammunitionQuantity, ammunitionLot, observations, format));
 
             await _unitWork.SaveChanges();

src/Armory/Formats/AssignedWeaponMagazineFormats/Application/AssignedWeaponMagazineFormatItemResponse.cs

@@ -0,0 +1,15 @@
+namespace Armory.Formats.AssignedWeaponMagazineFormats.Application
+{
+    public class AssignedWeaponMagazineFormatItemResponse
+    {
+        public int Id { get; init; }
+        public string TroopId { get; init; }
+        public string WeaponCode { get; init; }
+        public bool SafetyCartridge { get; init; }
+        public bool VerifiedInPhysical { get; init; }
+        public bool Novelty { get; init; }
+        public int AmmunitionQuantity { get; init; }
+        public string AmmunitionLot { get; init; }
+        public string Observations { get; init; }
+    }
+}

src/Armory/Formats/AssignedWeaponMagazineFormats/Application/AssignedWeaponMagazineFormatResponse.cs

@@ -4,19 +4,6 @@
 
 namespace Armory.Formats.AssignedWeaponMagazineFormats.Application
 {
-    public class AssignedWeaponMagazineFormatItemResponse
-    {
-        public int Id { get; init; }
-        public string TroopId { get; init; }
-        public string WeaponCode { get; init; }
-        public bool CartridgeOfLife { get; init; }
-        public bool VerifiedInPhysical { get; init; }
-        public bool Novelty { get; init; }
-        public int AmmunitionQuantity { get; init; }
-        public string AmmunitionLot { get; init; }
-        public string Observations { get; init; }
-    }
-
     public class AssignedWeaponMagazineFormatResponse
     {
         public int Id { get; init; }

src/Armory/Formats/AssignedWeaponMagazineFormats/Application/Generate/AssignedWeaponMagazineFormatGenerator.cs

@@ -113,7 +113,7 @@ private int MakeAssignedWeaponMagazineFormatItemsInfo(IXLWorksheet worksheet,
                         record.Weapon.NumberOfProviders.ToString(),
                         record.AmmunitionQuantity.ToString(),
                         record.AmmunitionLot,
-                        record.CartridgeOfLife ? "SI" : "NO",
+                        record.SafetyCartridge ? "SI" : "NO",
                         record.VerifiedInPhysical ? "SI" : "NO",
                         record.Novelty ? "SI" : "NO"
                     });

src/Armory/Formats/AssignedWeaponMagazineFormats/Domain/AssignedWeaponMagazineFormatItem.cs

@@ -7,13 +7,13 @@ namespace Armory.Formats.AssignedWeaponMagazineFormats.Domain
 {
     public class AssignedWeaponMagazineFormatItem
     {
-        public AssignedWeaponMagazineFormatItem(string troopId, string weaponCode, bool cartridgeOfLife,
+        public AssignedWeaponMagazineFormatItem(string troopId, string weaponCode, bool safetyCartridge,
             bool verifiedInPhysical, bool novelty, int ammunitionQuantity, string ammunitionLot, string observations,
             AssignedWeaponMagazineFormat format)
         {
             TroopId = troopId;
             WeaponCode = weaponCode;
-            CartridgeOfLife = cartridgeOfLife;
+            SafetyCartridge = safetyCartridge;
             VerifiedInPhysical = verifiedInPhysical;
             Novelty = novelty;
             AmmunitionQuantity = ammunitionQuantity;
@@ -34,7 +34,7 @@ internal AssignedWeaponMagazineFormatItem()
         [Required] public string WeaponCode { get; set; }
         [ForeignKey("WeaponCode")] public Weapon Weapon { get; set; }
 
-        public bool CartridgeOfLife { get; set; }
+        public bool SafetyCartridge { get; set; }
         public bool VerifiedInPhysical { get; set; }
         public bool Novelty { get; set; }
         [Required] public int AmmunitionQuantity { get; set; }
@@ -46,11 +46,11 @@ internal AssignedWeaponMagazineFormatItem()
         [ForeignKey("AssignedWeaponMagazineFormatId")]
         public AssignedWeaponMagazineFormat Format { get; set; }
 
-        public static AssignedWeaponMagazineFormatItem Create(string troopId, string weaponCode, bool cartridgeOfLife,
+        public static AssignedWeaponMagazineFormatItem Create(string troopId, string weaponCode, bool safetyCartridge,
             bool verifiedInPhysical, bool novelty, int ammunitionQuantity, string ammunitionLot, string observations,
             AssignedWeaponMagazineFormat format)
         {
-            return new AssignedWeaponMagazineFormatItem(troopId, weaponCode, cartridgeOfLife, verifiedInPhysical,
+            return new AssignedWeaponMagazineFormatItem(troopId, weaponCode, safetyCartridge, verifiedInPhysical,
                 novelty, ammunitionQuantity, ammunitionLot, observations, format);
         }
     }