Fix unnecessary re-downloads during updates: #9

Author: Chocapikk

.goreleaser.yaml

@@ -26,7 +26,7 @@ builds:
       - 6
       - 7
     ldflags:
-      - "-s -w -X github.com/Chocapikk/wpprobe/cmd.version=v{{ .Version }}"
+      - "-s -w -X github.com/Chocapikk/wpprobe/utils.Version=v{{ .Version }}"
 
   - id: wpprobe-android
     main: ./main.go
@@ -43,7 +43,7 @@ builds:
       - 6
       - 7
     ldflags:
-      - "-s -w -X github.com/Chocapikk/wpprobe/cmd.version=v{{ .Version }}"
+      - "-s -w -X github.com/Chocapikk/wpprobe/utils.Version=v{{ .Version }}"
 
 archives:
   - id: custom

cmd/root.go

@@ -26,18 +26,16 @@ import (
 	"github.com/spf13/cobra"
 )
 
-var version = "dev"
-
 var rootCmd = &cobra.Command{
 	Use:     "wpprobe",
 	Short:   "A fast WordPress plugin enumeration tool",
 	Long:    `WPProbe is a high-speed WordPress plugin scanner that detects installed plugins and checks for known vulnerabilities using the Wordfence database.`,
-	Version: version,
+	Version: utils.Version,
 }
 
 func Execute() {
-	_, isLatest := utils.CheckLatestVersion(version)
-	utils.DefaultLogger.PrintBanner(version, isLatest)
+	_, isLatest := utils.CheckLatestVersion(utils.Version)
+	utils.DefaultLogger.PrintBanner(utils.Version, isLatest)
 
 	if err := rootCmd.Execute(); err != nil {
 		utils.DefaultLogger.Error(err.Error())
@@ -50,7 +48,7 @@ func init() {
 	rootCmd.AddCommand(updateCmd)
 	rootCmd.AddCommand(updateDbCmd)
 
-	rootCmd.SetVersionTemplate("WPProbe version {{.Version}}\n")
+	rootCmd.SetVersionTemplate("WPProbe version {{.utils.Version}}\n")
 
 	rootCmd.SilenceErrors = true
 

cmd/update.go

@@ -28,7 +28,8 @@ var updateCmd = &cobra.Command{
 	Use:   "update",
 	Short: "Update WPProbe to the latest version",
 	Run: func(cmd *cobra.Command, args []string) {
-		if err := utils.AutoUpdate(); err != nil {
+		current := utils.Version
+		if err := utils.AutoUpdate(current); err != nil {
 			utils.DefaultLogger.Error("Update failed: " + err.Error())
 		} else {
 			utils.DefaultLogger.Success("Update completed successfully!")

internal/utils/update.go

@@ -30,6 +30,8 @@ import (
 
 const githubRepo = "Chocapikk/wpprobe"
 
+var Version = "dev"
+
 var exitFunc = os.Exit
 
 var GitHubLatestReleaseURL = func() string {
@@ -59,7 +61,7 @@ func getLatestVersion() (string, error) {
 		DefaultLogger.Error("Failed to fetch latest release: " + err.Error())
 		return "", err
 	}
-	defer func() { _ = resp.Body.Close() }()
+	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK {
 		DefaultLogger.Error(fmt.Sprintf("GitHub API error: %d", resp.StatusCode))
@@ -82,25 +84,32 @@ func getLatestVersion() (string, error) {
 	return version, nil
 }
 
-func AutoUpdate() error {
+func AutoUpdate(currentVersion string) error {
 	DefaultLogger.Info("Checking for WPProbe updates...")
 
-	version, err := getLatestVersion()
+	latest, err := getLatestVersion()
 	if err != nil {
 		return err
 	}
 
+	if currentVersion == latest {
+		DefaultLogger.Info(
+			fmt.Sprintf("WPProbe is already up-to-date (version %s)", currentVersion),
+		)
+		return nil
+	}
+
 	osName := detectOS()
 	arch := detectArch()
-	updateURL := GitHubDownloadURL(version, osName, arch)
+	updateURL := GitHubDownloadURL(latest, osName, arch)
 
 	DefaultLogger.Info("Downloading WPProbe update from: " + updateURL)
 	resp, err := http.Get(updateURL)
 	if err != nil {
 		DefaultLogger.Error("Failed to download update: " + err.Error())
 		return err
 	}
-	defer func() { _ = resp.Body.Close() }()
+	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK {
 		DefaultLogger.Error(fmt.Sprintf("Update not found: %s", updateURL))
@@ -145,10 +154,6 @@ func AutoUpdate() error {
 	return nil
 }
 
-func detectOS() string {
-	return runtime.GOOS
-}
+func detectOS() string { return runtime.GOOS }
 
-func detectArch() string {
-	return runtime.GOARCH
-}
+func detectArch() string { return runtime.GOARCH }

internal/utils/update_test.go

@@ -126,7 +126,7 @@ func TestAutoUpdate(t *testing.T) {
 			http.NotFound(w, r)
 		}
 	}))
-	defer func() { mockServer.Close() }()
+	defer mockServer.Close()
 
 	originalGitHubLatest := GitHubLatestReleaseURL
 	originalGitHubDownload := GitHubDownloadURL
@@ -166,7 +166,7 @@ func TestAutoUpdate(t *testing.T) {
 	os.Args[0] = tmpFile.Name()
 	defer func() { os.Args[0] = originalArg0 }()
 
-	if err := AutoUpdate(); err != nil {
+	if err := AutoUpdate(Version); err != nil {
 		t.Errorf("AutoUpdate() error = %v, want nil", err)
 	}
 	if !exitCalled {
@@ -185,7 +185,7 @@ func TestAutoUpdate_NotFound(t *testing.T) {
 
 	GitHubLatestReleaseURL = func() string { return mockServer.URL + "/repos/Chocapikk/wpprobe/releases/latest" }
 
-	err := AutoUpdate()
+	err := AutoUpdate(Version)
 	if err == nil {
 		t.Error("Expected error for 404, got nil")
 	}