Merge pull request #132 from Code-Institute-Org/fix_position_alert_for_duplicate_modules

ray-codeinstitute · web-flow · commit 2986d5428b21 · 2025-02-04T16:28:25.000Z
Attempting to fix bug where students has activity from multiple dupli…
diff --git a/common/lib/xmodule/xmodule/js/src/sequence/display.js b/common/lib/xmodule/xmodule/js/src/sequence/display.js
@@ -302,6 +302,10 @@
                 newPosition = $(event.currentTarget).data('element');
             }
 
+            // attempting to fix error where a student has activity from multiple duplicate courses (same xblockid)
+            if (newPosition < 1) { newPosition = 1; }
+            if (newPosition > this.num_contents) { newPosition = this.num_contents; }
+
             if ((newPosition >= 1) && (newPosition <= this.num_contents)) {
                 isBottomNav = $(event.target).closest('nav[class="sequence-bottom"]').length > 0;
 

Original file line number	Diff line number	Diff line change
`@@ -302,6 +302,10 @@`
`302`	`302`	`newPosition = $(event.currentTarget).data('element');`
`303`	`303`	`}`
`304`	`304`
	`305`	`+ // attempting to fix error where a student has activity from multiple duplicate courses (same xblockid)`
	`306`	`+ if (newPosition < 1) { newPosition = 1; }`
	`307`	`+ if (newPosition > this.num_contents) { newPosition = this.num_contents; }`
	`308`	`+`
`305`	`309`	`if ((newPosition >= 1) && (newPosition <= this.num_contents)) {`
`306`	`310`	`isBottomNav = $(event.target).closest('nav[class="sequence-bottom"]').length > 0;`
`307`	`311`