Merge pull request dubinc#2827 from dubinc/lead-noop

Add noop response to /track/lead (instead of error)

Author: steven-tey

apps/web/lib/api/conversions/track-sale.ts

@@ -123,15 +123,15 @@ export const trackSale = async ({
     }
   }
 
-  // No existing customer is found, find the click event and create a new customer (for sale tracking without a pre-existing lead event)
+  // No existing customer is found, find the click event and create a new customer (for direct sale tracking)
   else {
     if (!clickId) {
       waitUntil(
         logConversionEvent({
           workspace_id: workspace.id,
           path: "/track/sale",
           body: JSON.stringify(rawBody),
-          error: `No existing customer with the provided customerExternalId (${customerExternalId}) was found, and there was no clickId provided for sale tracking without a pre-existing lead event.`,
+          error: `No existing customer with the provided customerExternalId (${customerExternalId}) was found, and there was no clickId provided for direct sale tracking.`,
         }),
       );
 

apps/web/lib/zod/schemas/sales.ts

@@ -57,46 +57,42 @@ export const trackSaleRequestSchema = z.object({
     .describe(
       "Additional metadata to be stored with the sale event. Max 10,000 characters when stringified.",
     ),
-  // advanced fields: leadEventName + fields for sale tracking without a pre-existing lead event
+  // advanced fields: leadEventName + fields for sale tracking without a  lead event
   leadEventName: z
     .string()
     .nullish()
     .default(null)
     .describe(
-      "The name of the lead event that occurred before the sale (case-sensitive). This is used to associate the sale event with a particular lead event (instead of the latest lead event for a link-customer combination, which is the default behavior). For sale tracking without a pre-existing lead event, this field can also be used to specify the lead event name.",
+      "The name of the lead event that occurred before the sale (case-sensitive). This is used to associate the sale event with a particular lead event (instead of the latest lead event for a link-customer combination, which is the default behavior). For direct sale tracking, this field can also be used to specify the lead event name.",
     )
     .openapi({ example: "Cloned template 1481267" }),
   clickId: z
     .string()
     .trim()
     .nullish()
     .describe(
-      "[For sale tracking without a pre-existing lead event]: The unique ID of the click that the sale conversion event is attributed to. You can read this value from `dub_id` cookie.",
+      "[For direct sale tracking]: The unique ID of the click that the sale conversion event is attributed to. You can read this value from `dub_id` cookie.",
     ),
   customerName: z
     .string()
     .max(100)
     .nullish()
     .default(null)
     .describe(
-      "[For sale tracking without a pre-existing lead event]: The name of the customer. If not passed, a random name will be generated (e.g. “Big Red Caribou”).",
+      "[For direct sale tracking]: The name of the customer. If not passed, a random name will be generated (e.g. “Big Red Caribou”).",
     ),
   customerEmail: z
     .string()
     .email()
     .max(100)
     .nullish()
     .default(null)
-    .describe(
-      "[For sale tracking without a pre-existing lead event]: The email address of the customer.",
-    ),
+    .describe("[For direct sale tracking]: The email address of the customer."),
   customerAvatar: z
     .string()
     .nullish()
     .default(null)
-    .describe(
-      "[For sale tracking without a pre-existing lead event]: The avatar URL of the customer.",
-    ),
+    .describe("[For direct sale tracking]: The avatar URL of the customer."),
 });
 
 export const trackSaleResponseSchema = z.object({

apps/web/tests/tracks/track-sale.test.ts

@@ -227,7 +227,7 @@ describe("POST /track/sale", async () => {
     expect(response.data.sale?.amount).toBeLessThanOrEqual(1100); // 1100 cents
   });
 
-  test("track a sale without a pre-existing lead event", async () => {
+  test("track a sale with direct sale tracking", async () => {
     const clickResponse = await http.post<{ clickId: string }>({
       path: "/track/click",
       headers: E2E_TRACK_CLICK_HEADERS,