Merge pull request #963 from Codeinwp/remove/height_cap

update: modified limit_height

Author: selul

inc/settings.php

@@ -67,7 +67,7 @@ class Optml_Settings {
 		'retina_images'              => 'disabled',
 		'lazyload_type'              => 'fixed',
 		'limit_dimensions'           => 'enabled',
-		'limit_height'               => 1080,
+		'limit_height'               => 4000,
 		'limit_width'                => 1920,
 		'resize_smart'               => 'disabled',
 		'no_script'                  => 'disabled',

tests/test-replacer.php

@@ -233,13 +233,13 @@ public function test_limit_dimensions_default() {
 
 		$replaced_content = Optml_Manager::instance()->process_images_from_content( self::IMG_TAGS_LIMIT_DIMENSIONS['portrait'] );
 		$this->assertStringContainsString( 'i.optimole.com', $replaced_content );
-		$this->assertStringContainsString( '/w:720/', $replaced_content );
-		$this->assertStringContainsString( '/h:1080/', $replaced_content );
+		$this->assertStringContainsString( '/w:1920/', $replaced_content );
+		$this->assertStringContainsString( '/h:2880/', $replaced_content ); // the height is 1.5 times the width because the original image is 2:3 ratio
 
 		$replaced_content = Optml_Manager::instance()->process_images_from_content( self::IMG_TAGS_LIMIT_DIMENSIONS['landscape'] );
 		$this->assertStringContainsString( 'i.optimole.com', $replaced_content );
-		$this->assertStringContainsString( '/w:1620/', $replaced_content );
-		$this->assertStringContainsString( '/h:1080/', $replaced_content );
+		$this->assertStringContainsString( '/w:1920/', $replaced_content );
+		$this->assertStringContainsString( '/h:1280/', $replaced_content );
 
 		$replaced_content = Optml_Manager::instance()->process_images_from_content( self::IMG_TAGS_LIMIT_DIMENSIONS['equal'] );
 		$this->assertStringContainsString( 'i.optimole.com', $replaced_content );