Split GH actions test execution. Fix Cypress tests for running into GH Actions

Author: vilasmaciel

.github/workflows/nodejs.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       matrix:
         node-version: [12.x, 15.x]
-        mongodb-version: [4.0, 4.2]
+        mongodb-version: [4.2]
         elasticsearch-version: ['7.9.3']
         rabbitmq-version: ['3.8.2-management-alpine']
 
@@ -23,6 +23,10 @@ jobs:
         uses: wbari/start-mongoDB@v0.2
         with:
           mongoDBVersion: ${{ matrix.mongodb-version }}
+      - name: Launch RabbitMQ
+        uses: nijel/rabbitmq-action@v1.0.0
+        with:
+          rabbitmq version: ${{ matrix.rabbitmq-version }}
       - name: Configure sysctl limits
         run: |
           sudo swapoff -a
@@ -41,16 +45,17 @@ jobs:
       - name: npm install
         run: |
           npm install
-        env:
-          CI: true
       - name: npm run build
         run: |
           npm run build --if-present
           npm run lint
-        env:
-          CI: true
       - name: npm test
         run: |
           npm test
+      - name: Cypress run
+        uses: cypress-io/github-action@v1
         env:
-          CI: true
+          NODE_ENV: end2end
+          ACTIONS_ALLOW_UNSECURE_COMMANDS: true
+        with:
+          start: npm run cypress:ci:start

cypress.json

@@ -1,4 +1,5 @@
 {
+  "baseUrl": "http://localhost:8032",
   "video": false,
   "screenshotOnRunFailure": false,
   "testFiles": "**/*.cypress.*",

package.json

@@ -14,7 +14,7 @@
     "dev:mooc:backend": "NODE_ENV=dev ts-node-dev --ignore-watch node_modules  ./src/apps/mooc/backend/start.ts",
     "dev:backoffice:frontend": "NODE_ENV=dev ts-node-dev --ignore-watch node_modules ./src/apps/backoffice/frontend/start.ts",
     "dev:backoffice:backend": "NODE_ENV=dev ts-node-dev --ignore-watch node_modules ./src/apps/backoffice/backend/start.ts",
-    "test": "npm run test:unit && npm run test:features && npm run cypress:run",
+    "test": "npm run test:unit && npm run test:features",
     "test:unit": "NODE_ENV=test jest",
     "test:features": "npm run test:mooc:backend:features && npm run test:backoffice:backend:features",
     "test:mooc:backend:features": "NODE_ENV=test cucumber-js -p mooc_backend",
@@ -28,7 +28,8 @@
     "build:di": "copy 'src/**/*.{json,yaml,html,png}' dist/src",
     "build:clean": "rm -r dist; exit 0",
     "cypress:open": "NODE_ENV=end2end ts-node tests/utils/cypress/open",
-    "cypress:run": "NODE_ENV=end2end ts-node tests/utils/cypress/run"
+    "cypress:run": "NODE_ENV=end2end ts-node tests/utils/cypress/run",
+    "cypress:ci:start": "NODE_ENV=end2end ts-node tests/utils/cypress/startApps"
   },
   "dependencies": {
     "@types/amqplib": "^0.5.17",

src/Contexts/Shared/infrastructure/WinstonLogger.ts

@@ -1,5 +1,5 @@
 import Logger from '../domain/Logger';
-import winston, { Logger as WinstonLoggerType } from 'winston';
+import winston, { format, Logger as WinstonLoggerType } from 'winston';
 
 enum Levels {
   DEBUG = 'debug',
@@ -12,6 +12,7 @@ class WinstonLogger implements Logger {
 
   constructor() {
     this.logger = winston.createLogger({
+      format: format.combine(format.splat(), format.simple()),
       transports: [
         new winston.transports.Console(),
         new winston.transports.File({ filename: `logs/${Levels.DEBUG}.log`, level: Levels.DEBUG }),

src/apps/mooc/backend/MoocBackendApp.ts

@@ -16,7 +16,7 @@ export class MoocBackendApp {
     return this.server.listen();
   }
 
-  async close() {
+  async stop() {
     return this.server?.stop();
   }
 

tests/apps/backoffice/frontend/features/courses/create_course.cypress.ts

@@ -6,6 +6,11 @@ describe('Create courses', () => {
     cy.task('reset:backoffice:db');
   });
 
+  after(() => {
+    cy.task('reset:mooc:db');
+    cy.task('reset:backoffice:db');
+  });
+
   beforeEach(() => {
     cy.visit('courses');
   });

tests/apps/backoffice/frontend/features/courses/list_courses.cypress.ts

@@ -8,6 +8,11 @@ describe('List courses', () => {
     cy.visit('courses');
   });
 
+  after(() => {
+    cy.task('reset:mooc:db');
+    cy.task('reset:backoffice:db');
+  });
+
   it('can list courses', () => {
     cy.get('input[name="name"]').type('DDD en Typescript');
     cy.get('input[name="duration"]').type('25 hours');

tests/apps/mooc/backend/features/step_definitions/controller.steps.ts

@@ -40,5 +40,5 @@ AfterAll(async () => {
   const environmentArranger: Promise<EnvironmentArranger> = container.get('Mooc.EnvironmentArranger');
   await (await environmentArranger).arrange();
   await (await environmentArranger).close();
-  await application.close();
+  await application.stop();
 });

tests/utils/cypress/Applications.ts

@@ -0,0 +1,27 @@
+import { BackofficeBackendApp } from '../../../src/apps/backoffice/backend/BackofficeBackendApp';
+import { BackofficeFrontendApp } from '../../../src/apps/backoffice/frontend/BackofficeFrontendApp';
+import { MoocBackendApp } from '../../../src/apps/mooc/backend/MoocBackendApp';
+
+export class Applications {
+  private static backofficeBackend: BackofficeBackendApp;
+  private static backofficeFrontend: BackofficeFrontendApp;
+  private static mooc: MoocBackendApp;
+
+  static async start() {
+    this.backofficeBackend = new BackofficeBackendApp();
+    this.backofficeFrontend = new BackofficeFrontendApp();
+    this.mooc = new MoocBackendApp();
+
+    await this.mooc.start();
+    await this.backofficeBackend.start();
+    await this.backofficeFrontend.start();
+
+    return this.backofficeFrontend.port;
+  }
+
+  static async stop() {
+    await this.mooc.stop();
+    await this.backofficeBackend.stop();
+    await this.backofficeFrontend.stop();
+  }
+}

tests/utils/cypress/open.ts

@@ -1,16 +1,11 @@
 import cypress from 'cypress';
-import { startBackofficeFrontend } from './startBackofficeFrontend';
-import { startBackofficeBackend } from './startBackofficeBackend';
-import { startMoocBackend } from './startMoocBackend';
+import { Applications } from './Applications';
 
 async function open() {
-  const backofficeFrontend = await startBackofficeFrontend();
-  const backofficeBackend = await startBackofficeBackend();
-  const moockBackend = await startMoocBackend();
-  const port = backofficeFrontend.port;
+  const port = await Applications.start();
   await runCypress(port);
 
-  await Promise.all([backofficeFrontend.stop(), backofficeBackend.stop(), moockBackend]);
+  await Applications.stop();
   process.exit(0);
 }