tagulous: remove duplicated fields

Author: valentijnscholten

dojo/filters.py

@@ -343,21 +343,33 @@ def __init__(self, *args, **kwargs):
         for field in ["tags", "test__tags", "test__engagement__tags", "test__engagement__product__tags",
                         "not_tags", "not_test__tags", "not_test__engagement__tags", "not_test__engagement__product__tags"]:
             if field in self.form.fields:
-                tags_filter = self.filters["tags"]
-                model = tags_filter.model
+                # Remove the original filter field to prevent duplication
+                if field in self.filters:
+                    tags_filter = self.filters[field]
+                    model = tags_filter.model
+                else:
+                    # Fallback to the 'tags' filter if specific field filter doesn't exist
+                    tags_filter = self.filters["tags"]
+                    model = tags_filter.model
+
+                # Get the tagulous field from the model
+                tagulous_field = model._meta.get_field("tags").formfield()
 
-                self.form.fields[field] = model._meta.get_field("tags").formfield()
                 # we defer applying the select2 autocomplete because there can be multiple forms on the same page
                 # and form.js would then apply select2 multiple times, resulting in duplicated fields
                 # the initialization now happens in filter_js_snippet.html
-                self.form.fields[field].widget.tag_options += tagulous.models.options.TagOptions(autocomplete_settings={"width": "200px", "defer": True})
+                tagulous_field.widget.tag_options += tagulous.models.options.TagOptions(autocomplete_settings={"width": "200px", "defer": True})
+
                 tagged_model, exclude = get_tags_model_from_field_name(field)
                 if tagged_model:  # only if not the normal tags field
-                    self.form.fields[field].label = get_tags_label_from_model(tagged_model)
-                    self.form.fields[field].autocomplete_tags = tagged_model.tags.tag_model.objects.all().order_by("name")
+                    tagulous_field.label = get_tags_label_from_model(tagged_model)
+                    tagulous_field.autocomplete_tags = tagged_model.tags.tag_model.objects.all().order_by("name")
 
                 if exclude:
-                    self.form.fields[field].label = "Not " + self.form.fields[field].label
+                    tagulous_field.label = "Not " + tagulous_field.label
+
+                # Replace the field completely
+                self.form.fields[field] = tagulous_field
 
 
 def get_tags_model_from_field_name(field):