Skip to content

Conversation

@kiblik
Copy link
Contributor

@kiblik kiblik commented Nov 12, 2025

Extend #13613 and #13520
Fix #13668 and #13666

This part is a bit hard for testing and writing it right on the first try. I hope this will finally work correctly.

@Maffooch Maffooch requested a review from Jino-T November 13, 2025 01:11
@Maffooch Maffooch added this to the 2.52.2 milestone Nov 13, 2025
Copy link
Contributor

@mtesauro mtesauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mtesauro mtesauro requested a review from rossops November 13, 2025 03:41
@valentijnscholten valentijnscholten merged commit 2171863 into DefectDojo:bugfix Nov 13, 2025
149 checks passed
@kiblik kiblik deleted the helm_fix_update_renovate branch November 13, 2025 16:55
@kiblik
Copy link
Contributor Author

kiblik commented Nov 13, 2025

@mtesauro & @Maffooch, I just found out that even after this PR, we still might be facing the issue of not triggering GHA, because if a new offered change is breaking sth, checks will pass (because unittests would not be triggered).

https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN, with the exception of workflow_dispatch and repository_dispatch, will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs. For example, if a workflow run pushes code using the repository's GITHUB_TOKEN, a new workflow will not run even when the repository contains a workflow configured to run when push events occur. For more information, see Use GITHUB_TOKEN for authentication in workflows.

If you do want to trigger a workflow from within a workflow run, you can use a GitHub App installation access token or a personal access token instead of GITHUB_TOKEN to trigger events that require a token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants