Skip to content

Commit 8b1f84c

Browse files
committed
Address comment
1 parent 930eef3 commit 8b1f84c

File tree

2 files changed

+23
-29
lines changed
  • exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc

2 files changed

+23
-29
lines changed

exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_log_exporter/__init__.py

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -90,22 +90,18 @@ def __init__(
9090
if compression is None
9191
else compression
9292
)
93-
endpoint = endpoint or environ.get(OTEL_EXPORTER_OTLP_LOGS_ENDPOINT)
9493

95-
headers = headers or environ.get(OTEL_EXPORTER_OTLP_LOGS_HEADERS)
96-
97-
super().__init__(
98-
**{
99-
"endpoint": endpoint,
100-
"insecure": insecure,
101-
"credentials": credentials,
102-
"headers": headers,
103-
"timeout": timeout or environ_timeout,
104-
"compression": compression,
105-
"stub": LogsServiceStub,
106-
"result": LogExportResult,
107-
"channel_options": channel_options,
108-
}
94+
OTLPExporterMixin.__init__(
95+
self,
96+
endpoint=endpoint or environ.get(OTEL_EXPORTER_OTLP_LOGS_ENDPOINT),
97+
insecure=insecure,
98+
credentials=credentials,
99+
headers=headers or environ.get(OTEL_EXPORTER_OTLP_LOGS_HEADERS),
100+
timeout=timeout,
101+
compression=compression,
102+
stub=LogsServiceStub,
103+
result=LogExportResult,
104+
channel_options=channel_options,
109105
)
110106

111107
def _translate_data(

exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/trace_exporter/__init__.py

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -123,20 +123,18 @@ def __init__(
123123
else compression
124124
)
125125

126-
super().__init__(
127-
**{
128-
"stub": TraceServiceStub,
129-
"result": SpanExportResult,
130-
"endpoint": endpoint
131-
or environ.get(OTEL_EXPORTER_OTLP_TRACES_ENDPOINT),
132-
"insecure": insecure,
133-
"credentials": credentials,
134-
"headers": headers
135-
or environ.get(OTEL_EXPORTER_OTLP_TRACES_HEADERS),
136-
"timeout": timeout or environ_timeout,
137-
"compression": compression,
138-
"channel_options": channel_options,
139-
}
126+
OTLPExporterMixin.__init__(
127+
self,
128+
stub=TraceServiceStub,
129+
result=SpanExportResult,
130+
endpoint=endpoint
131+
or environ.get(OTEL_EXPORTER_OTLP_TRACES_ENDPOINT),
132+
insecure=insecure,
133+
credentials=credentials,
134+
headers=headers or environ.get(OTEL_EXPORTER_OTLP_TRACES_HEADERS),
135+
timeout=timeout or environ_timeout,
136+
compression=compression,
137+
channel_options=channel_options,
140138
)
141139

142140
def _translate_data(

0 commit comments

Comments
 (0)