clean regex

Author: QuentinGab

src/SerialNumberGenerator.php

@@ -165,12 +165,12 @@ protected function formatToRegex(): string
     {
         $value = preg_replace_callback_array(
             [
-                '/[^\w\s]/i' => fn ($matches) => $matches[0] ? "\\{$matches[0]}" : '',
-                '/P+/' => fn ($matches) => ($matches[0] && $length = mb_strlen($matches[0])) ? "(?<prefix>[a-zA-Z]{{$length}})" : '',
-                '/S+/' => fn ($matches) => ($matches[0] && $length = mb_strlen($matches[0])) ? "(?<serie>\d{{$length}})" : '',
-                '/M+/' => fn ($matches) => ($matches[0] && $length = mb_strlen($matches[0])) ? "(?<month>\d{{$length}})" : '',
-                '/Y+/' => fn ($matches) => ($matches[0] && $length = mb_strlen($matches[0])) ? "(?<year>\d{{$length}})" : '',
-                '/C+/' => fn ($matches) => ($matches[0] && $length = mb_strlen($matches[0])) ? "(?<count>\d{{$length}})" : '',
+                '/[^\w\s]/i' => fn ($matches) => "\\{$matches[0]}",
+                '/P+/' => fn ($matches) => ($length = mb_strlen($matches[0])) ? "(?<prefix>[a-zA-Z]{{$length}})" : '',
+                '/S+/' => fn ($matches) => ($length = mb_strlen($matches[0])) ? "(?<serie>\d{{$length}})" : '',
+                '/M+/' => fn ($matches) => ($length = mb_strlen($matches[0])) ? "(?<month>\d{{$length}})" : '',
+                '/Y+/' => fn ($matches) => ($length = mb_strlen($matches[0])) ? "(?<year>\d{{$length}})" : '',
+                '/C+/' => fn ($matches) => ($length = mb_strlen($matches[0])) ? "(?<count>\d{{$length}})" : '',
             ],
             $this->format
         );

tests/Unit/SerialNumberTest.php

@@ -21,6 +21,7 @@
     ['CCCC\YY', '0002\25', null, null, 25, null, 2],
     ['CCCC.YY', '0002.25', null, null, 25, null, 2],
     ['CCCC|YY', '0002|25', null, null, 25, null, 2],
+    ['PPP-SSS..CCCC/YY', 'INV-999..0001/25', 'INV', 999, 25, null, 1],
 ];
 
 it('can generate serial number from format', function ($format, $serialNumber, $prefix, $serie, $year, $month, $count) {