From 5e6930cf3d94bf195b1f1139f25ec2f54757690c Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Tue, 20 Jun 2023 21:59:02 +0200 Subject: [PATCH 1/7] fix: add missing properties to ExportChannelStatusResponse --- src/types.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/types.ts b/src/types.ts index 54294b765b..1c21678182 100644 --- a/src/types.ts +++ b/src/types.ts @@ -382,6 +382,8 @@ export type ExportUsersResponse = { }; export type ExportChannelStatusResponse = { + status: string; + task_id: string; created_at?: string; error?: {}; result?: {}; From f017f853c633e82f79859ab2fb21253c58cad4ba Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Tue, 20 Jun 2023 22:09:39 +0200 Subject: [PATCH 2/7] add types for result --- src/types.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/types.ts b/src/types.ts index 1c21678182..f1b0997e3a 100644 --- a/src/types.ts +++ b/src/types.ts @@ -381,12 +381,18 @@ export type ExportUsersResponse = { task_id: string; }; +export type ExportChannelsResult = { + path?: string; + s3_bucket_name?: string; + url?: string; +}; + export type ExportChannelStatusResponse = { status: string; task_id: string; created_at?: string; - error?: {}; - result?: {}; + error?: ExportChannelsResult | null; + result?: {} | null; updated_at?: string; }; From 1e6c18c3d4f971ca74b99eae266512c3ff033fc3 Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Wed, 29 Nov 2023 16:15:26 +0100 Subject: [PATCH 3/7] address review comment --- src/types.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/types.ts b/src/types.ts index 5603e9d99d..54f59c4fe2 100644 --- a/src/types.ts +++ b/src/types.ts @@ -405,12 +405,19 @@ export type ExportChannelsResult = { url?: string; }; +export type ExportChannelError = { + description?: string; + stacktrace?: string; + type?: string; + version?: string; +}; + export type ExportChannelStatusResponse = { status: string; task_id: string; created_at?: string; - error?: ExportChannelsResult | null; - result?: {} | null; + error?: ExportChannelError | null; + result?: ExportChannelsResult | null; updated_at?: string; }; From 332334ea31eab1b46043843a4f19b625d1e33e27 Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Wed, 29 Nov 2023 16:41:06 +0100 Subject: [PATCH 4/7] updates --- src/types.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/types.ts b/src/types.ts index 54f59c4fe2..347e6e89b4 100644 --- a/src/types.ts +++ b/src/types.ts @@ -408,16 +408,19 @@ export type ExportChannelsResult = { export type ExportChannelError = { description?: string; stacktrace?: string; + status?: string; + task_id?: string; type?: string; version?: string; }; export type ExportChannelStatusResponse = { - status: string; + duration: string; task_id: string; created_at?: string; - error?: ExportChannelError | null; + error?: ExportChannelError; result?: ExportChannelsResult | null; + status?: string; updated_at?: string; }; From cefc6c364eea3c1edd0292b851c591e757a56d8f Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Wed, 29 Nov 2023 16:42:22 +0100 Subject: [PATCH 5/7] never mind --- src/types.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/types.ts b/src/types.ts index 347e6e89b4..f51af4f055 100644 --- a/src/types.ts +++ b/src/types.ts @@ -415,12 +415,11 @@ export type ExportChannelError = { }; export type ExportChannelStatusResponse = { - duration: string; + status: string; task_id: string; created_at?: string; error?: ExportChannelError; result?: ExportChannelsResult | null; - status?: string; updated_at?: string; }; From cb776c5d13c469d9b950b57fa228b03c1b14a3b8 Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Thu, 30 Nov 2023 13:22:03 +0100 Subject: [PATCH 6/7] all optional --- src/types.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/types.ts b/src/types.ts index f51af4f055..633301bf8c 100644 --- a/src/types.ts +++ b/src/types.ts @@ -415,11 +415,11 @@ export type ExportChannelError = { }; export type ExportChannelStatusResponse = { - status: string; - task_id: string; created_at?: string; error?: ExportChannelError; result?: ExportChannelsResult | null; + status?: string; + task_id?: string; updated_at?: string; }; From 6941e9cf90452f7a96599d3f60eca3c44a115920 Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Thu, 30 Nov 2023 13:45:23 +0100 Subject: [PATCH 7/7] add duration --- src/types.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/types.ts b/src/types.ts index 633301bf8c..e81d287416 100644 --- a/src/types.ts +++ b/src/types.ts @@ -393,6 +393,7 @@ export type EventAPIResponse