Skip to content

Commit 6f3f5fd

Browse files
committed
refactor: Enhance numeric parsing in NumericFormatter
1 parent 66fe10b commit 6f3f5fd

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/GitVersion.Core/Formatting/NumericFormatter.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,21 @@ public override bool TryFormat(object? value, string format, CultureInfo culture
1414
return false;
1515

1616
// Integer formatting
17-
if (format.All(char.IsDigit) && int.TryParse(s, out var i))
17+
if (format.All(char.IsDigit) && int.TryParse(s, NumberStyles.Integer, cultureInfo, out var i))
1818
{
1919
result = i.ToString(format, cultureInfo);
2020
return true;
2121
}
2222

2323
// Hexadecimal formatting
24-
if (format.StartsWith("X", StringComparison.OrdinalIgnoreCase) && int.TryParse(s, out var hex))
24+
if (format.StartsWith("X", StringComparison.OrdinalIgnoreCase) && int.TryParse(s, NumberStyles.Integer, cultureInfo, out var hex))
2525
{
2626
result = hex.ToString(format, cultureInfo);
2727
return true;
2828
}
2929

3030
// Floating point formatting
31-
if ("FEGNCP".Contains(char.ToUpperInvariant(format[0])) && double.TryParse(s, out var d))
31+
if ("FEGNCP".Contains(char.ToUpperInvariant(format[0])) && double.TryParse(s, NumberStyles.Float | NumberStyles.AllowThousands, cultureInfo, out var d))
3232
{
3333
result = d.ToString(format, cultureInfo);
3434
return true;

0 commit comments

Comments
 (0)