Merge remote-tracking branch 'origin/main' into gbo/rnd-7359

Author: Nicolas Dorseuil

.changeset/brown-ducks-think.md

@@ -0,0 +1,5 @@
+---
+"gitbook": patch
+---
+
+Hide scrollbar on sections

.changeset/plenty-laws-buy.md

@@ -0,0 +1,5 @@
+---
+"gitbook": minor
+---
+
+Add support for site customization option to change how external links open.

.changeset/spotty-apples-crash.md

@@ -0,0 +1,6 @@
+---
+'@gitbook/openapi-parser': patch
+'@gitbook/react-openapi': patch
+---
+
+Optional label in OpenAPI x-codeSamples

bun.lock

@@ -36,7 +36,7 @@
     "workspaces": {
         "packages": ["packages/*"],
         "catalog": {
-            "@gitbook/api": "^0.122.0"
+            "@gitbook/api": "^0.123.0"
         }
     },
     "patchedDependencies": {

package.json

@@ -122,6 +122,11 @@
             ]
         },
         "production": {
+            "vars": {
+                // This is a bit misleading, but it means that we can have 500 concurrent revalidations
+                // This means that we'll have up to 100 durable objects instance running at the same time
+                "MAX_REVALIDATE_CONCURRENCY": "100"
+            },
             "r2_buckets": [
                 {
                     "binding": "NEXT_INC_CACHE_R2_BUCKET",

packages/gitbook-v2/openNext/customWorkers/defaultWrangler.jsonc

@@ -98,7 +98,11 @@
         },
         "production": {
             "vars": {
+                // R2 is strongly consistent, so we can disable SQLite
                 "NEXT_CACHE_DO_QUEUE_DISABLE_SQLITE": "true",
+                // We don't want to pollute the memory with broken cache entries
+                // Most of the time, those are fake requests.
+                "NEXT_CACHE_DO_QUEUE_MAX_RETRIES": "1",
                 "STAGE": "production"
             },
             "r2_buckets": [

packages/gitbook-v2/openNext/customWorkers/doWrangler.jsonc

@@ -35,8 +35,9 @@ describe('toPathInSpace', () => {
         expect(variantInSection.toPathInSpace('some/path/')).toBe('/section/variant/some/path');
     });
 
-    it('should not add a trailing slash', () => {
-        expect(root.toPathInSpace('')).toBe('');
+    it('should not add an unnecessary trailing slash', () => {
+        // The index page should not be an empty path
+        expect(root.toPathInSpace('')).toBe('/');
         expect(variantInSection.toPathInSpace('')).toBe('/section/variant');
     });
 });
@@ -52,8 +53,9 @@ describe('toPathInSite', () => {
         expect(siteGitBookIO.toPathInSite('some/path/')).toBe('/sitename/some/path');
     });
 
-    it('should not add a trailing slash', () => {
-        expect(root.toPathInSite('')).toBe('');
+    it('should not add an unnecessary trailing slash', () => {
+        // The index page should not be an empty path
+        expect(root.toPathInSite('')).toBe('/');
         expect(siteGitBookIO.toPathInSite('')).toBe('/sitename');
     });
 });

packages/gitbook-v2/src/lib/links.test.ts

@@ -128,7 +128,8 @@ export function createLinker(
 function joinPaths(prefix: string, path: string): string {
     const prefixPath = prefix.endsWith('/') ? prefix : `${prefix}/`;
     const suffixPath = path.startsWith('/') ? path.slice(1) : path;
-    return removeTrailingSlash(prefixPath + suffixPath);
+    const pathWithoutTrailingSlash = removeTrailingSlash(prefixPath + suffixPath);
+    return pathWithoutTrailingSlash === '' ? '/' : pathWithoutTrailingSlash;
 }
 
 function removeTrailingSlash(path: string): string {

packages/gitbook-v2/src/lib/links.ts

@@ -16,6 +16,7 @@ import {
     CustomizationThemeMode,
     type CustomizationThemedColor,
     type SiteCustomizationSettings,
+    SiteExternalLinksTarget,
 } from '@gitbook/api';
 import { type BrowserContext, type Page, type Response, expect, test } from '@playwright/test';
 import deepMerge from 'deepmerge';
@@ -317,6 +318,9 @@ export function getCustomizationURL(partial: DeepPartial<SiteCustomizationSettin
         aiSearch: {
             enabled: true,
         },
+        externalLinks: {
+            target: SiteExternalLinksTarget.Self,
+        },
         advancedCustomization: {
             enabled: true,
         },