From 22e069aaeba3a5eba7b11101aa5bd5616fd438a2 Mon Sep 17 00:00:00 2001 From: Holt Skinner <13262395+holtskinner@users.noreply.github.com> Date: Wed, 23 Jul 2025 17:42:17 +0100 Subject: [PATCH 1/4] Update answer_query_sample.py --- discoveryengine/answer_query_sample.py | 1 + 1 file changed, 1 insertion(+) diff --git a/discoveryengine/answer_query_sample.py b/discoveryengine/answer_query_sample.py index 5f546ab6f7d..ed258f51d3e 100644 --- a/discoveryengine/answer_query_sample.py +++ b/discoveryengine/answer_query_sample.py @@ -85,6 +85,7 @@ def answer_query_sample( session=None, # Optional: include previous session ID to continue a conversation query_understanding_spec=query_understanding_spec, answer_generation_spec=answer_generation_spec, + user_pseudo_id="user-pseudo-id", # Optional: Add user pseudo-identifier for queries. ) # Make the request From a4e6e397980ed83c0111f3d79b2780ad5feda96c Mon Sep 17 00:00:00 2001 From: Holt Skinner Date: Wed, 23 Jul 2025 18:13:38 +0100 Subject: [PATCH 2/4] Fix lint errors --- discoveryengine/answer_query_sample.py | 2 +- discoveryengine/documents_sample_test.py | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/discoveryengine/answer_query_sample.py b/discoveryengine/answer_query_sample.py index ed258f51d3e..80e02e0c7c5 100644 --- a/discoveryengine/answer_query_sample.py +++ b/discoveryengine/answer_query_sample.py @@ -85,7 +85,7 @@ def answer_query_sample( session=None, # Optional: include previous session ID to continue a conversation query_understanding_spec=query_understanding_spec, answer_generation_spec=answer_generation_spec, - user_pseudo_id="user-pseudo-id", # Optional: Add user pseudo-identifier for queries. + user_pseudo_id="user-pseudo-id", # Optional: Add user pseudo-identifier for queries. ) # Make the request diff --git a/discoveryengine/documents_sample_test.py b/discoveryengine/documents_sample_test.py index 1e1b6af84db..ac1d0e45989 100644 --- a/discoveryengine/documents_sample_test.py +++ b/discoveryengine/documents_sample_test.py @@ -15,17 +15,20 @@ import os -from discoveryengine import import_documents_sample -from discoveryengine import list_documents_sample -from discoveryengine import purge_documents_sample - import pytest +from discoveryengine import ( + import_documents_sample, + list_documents_sample, + purge_documents_sample, +) + project_id = os.environ["GOOGLE_CLOUD_PROJECT"] location = "global" data_store_id = "test-structured-data-engine" +@pytest.mark.skip(reason="Table deleted.") def test_import_documents_bigquery(): # Empty Dataset bigquery_dataset = "genappbuilder_test" From 2327ecc2d34e9f9f2ab5d8fa1367230a25ecd03b Mon Sep 17 00:00:00 2001 From: Holt Skinner <13262395+holtskinner@users.noreply.github.com> Date: Tue, 29 Jul 2025 16:45:33 +0100 Subject: [PATCH 3/4] Apply suggestions from code review --- discoveryengine/documents_sample_test.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/discoveryengine/documents_sample_test.py b/discoveryengine/documents_sample_test.py index ac1d0e45989..4ee73ad68ca 100644 --- a/discoveryengine/documents_sample_test.py +++ b/discoveryengine/documents_sample_test.py @@ -17,11 +17,9 @@ import pytest -from discoveryengine import ( - import_documents_sample, - list_documents_sample, - purge_documents_sample, -) +from discoveryengine import import_documents_sample +from discoveryengine import list_documents_sample +from discoveryengine import purge_documents_sample project_id = os.environ["GOOGLE_CLOUD_PROJECT"] location = "global" From b66fd83c738d60b052957a66f649cf7fdfe6cf13 Mon Sep 17 00:00:00 2001 From: Holt Skinner <13262395+holtskinner@users.noreply.github.com> Date: Tue, 29 Jul 2025 16:46:32 +0100 Subject: [PATCH 4/4] Apply suggestions from code review --- discoveryengine/documents_sample_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/discoveryengine/documents_sample_test.py b/discoveryengine/documents_sample_test.py index 4ee73ad68ca..c94d56e59c2 100644 --- a/discoveryengine/documents_sample_test.py +++ b/discoveryengine/documents_sample_test.py @@ -15,12 +15,12 @@ import os -import pytest - from discoveryengine import import_documents_sample from discoveryengine import list_documents_sample from discoveryengine import purge_documents_sample +import pytest + project_id = os.environ["GOOGLE_CLOUD_PROJECT"] location = "global" data_store_id = "test-structured-data-engine"