add arrow shape feature in editor

[krVatsal]

Add a new arrow shape tool

Closes #3317

[timon-schelling]

!build

[github-actions]

📦 Build Complete for 989f4ba
https://8e0fa0ab.graphite.pages.dev

[timon-schelling]

I know still a draft, but a arrow node might be something to consider. Like it is done for all other shapes.

Thanks for the contribution :)

[Keavon]

I haven't read the (draft) PR's code, but what is the tooling doing if it's not controlling an arrow generator node?

[timon-schelling]

the (draft) PR's code, but what is the tooling doing if it's

creating a path node

[Keavon]

That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.

[krVatsal]

Sure @Keavon

[0HyperCube]

Note that this inserts the point in layer space. You said above that you Build arrow in viewport space.

To convert between the viewport and the layer space, you can do something like:

document.metadata().transform_to_viewport(layer).inverse().transform_point2(pos)

Alternatively you can set the transform on the layer itself:

responses.add(GraphOperationMessage::TransformSet {
	layer,
	transform: DAffine2::IDENTITY,
	transform_in: TransformIn::Viewport,
	skip_rerender: false,
});

Note that the line tool is broken and produces offset lines when inside a transformed parent layer. I would recommend that you avoid implementing this bug into you new tool.

[krVatsal]

Thanks for the help, i have modified it accordingly.

[github-actions]

📦 Build Complete for f3b1179
https://828f1024.graphite.pages.dev

[timon-schelling]

The arrow position is correct now, I would prefer if it was flipped though, starting at the base and dragging to the tip (just my opinion).

And reminder about the requirement of a new arrow node. Just a path node with arrow data generated by the tool is not enough. Take another look at other shape nodes (like Regular Polygon in the Image).

That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.

[krVatsal]

The arrow position is correct now, I would prefer if it was flipped though, starting at the base and dragging to the tip (just my opinion).

And reminder about the requirement of a new arrow node. Just a path node with arrow data generated by the tool is not enough. Take another look at other shape nodes (like Regular Polygon in the Image).

> That wouldn't allow the user to parametrically edit the arrow shape. The goal is to add handles to drag its width, length, arrow head's front and back angles, and arrow head width and height. That all has to be written to the parameters of an Arrow node. @krVatsal please be aware of these details for the requirements of this feature. Thank you.

Got it, I'll fix it soon!

[timon-schelling]

!build