Remove ptAgeVault.getAgesIOwnFolder in favor of .getBookshelfFolder

The implementation of the two methods is identical, so this doesn't
change any behavior.

However, the name getBookshelfFolder more accurately describes the
method's behavior and avoids confusion with ptVault.getAgesIOwnFolder,
which does *not* do the same thing as the ptAgeVault method:

* ptVault.getAgesIOwnFolder can be called in any age and returns the age
  instances owned by the current avatar.
* ptAgeVault.getBookshelfFolder (formerly ptAgeVault.getAgesIOwnFolder)
  only succeeds when in an instance of Relto and returns the age
  instances owned by the avatar that owns the Relto instance (i. e. the
  books appearing in that Relto instance's bookshelf).

These two lists will be different if one avatar is visiting another
avatar's Relto!

Author: dgelessus

Scripts/Python/plasma/Plasma.py

@@ -1187,10 +1187,6 @@ def getAgeSDL(self):
         """Returns the age's SDL (ptSDLStateDataRecord)"""
         ...
 
-    def getAgesIOwnFolder(self):
-        """(depreciated, use getBookshelfFolder) Returns a ptVaultFolderNode that contain the Ages I own"""
-        ...
-
     def getBookshelfFolder(self):
         """Personal age only: Returns a ptVaultFolderNode that contains the owning player's AgesIOwn age list"""
         ...

Scripts/Python/psnlBahroPoles.py

@@ -941,7 +941,7 @@ def FissureForceCamRgnHandle(self):
 
     def IsVolatile(self, age):
         ageVault = ptAgeVault()
-        PAL = ageVault.getAgesIOwnFolder()
+        PAL = ageVault.getBookshelfFolder()
         contents = PAL.getChildNodeRefList()
         for content in contents:
             link = content.getChild()
@@ -966,7 +966,7 @@ def BookLost(self, age):
             return 0
 
         ageVault = ptAgeVault()
-        PAL = ageVault.getAgesIOwnFolder()
+        PAL = ageVault.getBookshelfFolder()
         contents = PAL.getChildNodeRefList()
         for content in contents:
             link = content.getChild()
@@ -1079,9 +1079,9 @@ def ValidityCheck(self):
 
     def UpdateToState2(self):
         vault = ptAgeVault()
-        myAges = vault.getAgesIOwnFolder()
-        myAges = myAges.getChildNodeRefList()
-        for ageInfo in myAges:
+        PAL = vault.getBookshelfFolder()
+        contents = PAL.getChildNodeRefList()
+        for ageInfo in contents:
             link = ageInfo.getChild()
             link = link.upcastToAgeLinkNode()
             info = link.getAgeInfo()

Scripts/Python/psnlBookshelf.py

@@ -456,7 +456,7 @@ def OnNotify(self,state,id,events):
                                 note.send()
 
                                 ageVault = ptAgeVault()
-                                PAL = ageVault.getAgesIOwnFolder()
+                                PAL = ageVault.getBookshelfFolder()
                                 contents = PAL.getChildNodeRefList()
                                 for content in contents:
                                     link = content.getChild()
@@ -1056,7 +1056,7 @@ def OnNotify(self,state,id,events):
                     note.send()
 
                     ageVault = ptAgeVault()
-                    PAL = ageVault.getAgesIOwnFolder()
+                    PAL = ageVault.getBookshelfFolder()
                     contents = PAL.getChildNodeRefList()
                     for content in contents:
                         link = content.getChild()
@@ -1213,7 +1213,7 @@ def IGetLinkFromBook(self, spTitle = None):
             return ageLink
 
         ageVault = ptAgeVault()
-        PAL = ageVault.getAgesIOwnFolder()
+        PAL = ageVault.getBookshelfFolder()
         contents = PAL.getChildNodeRefList()
         for content in contents:
             link = content.getChild()
@@ -1245,7 +1245,7 @@ def IUpdateLocksAndTrays(self):
         global CityBookAges
 
         ageVault = ptAgeVault()
-        PAL = ageVault.getAgesIOwnFolder()
+        PAL = ageVault.getBookshelfFolder()
         contents = PAL.getChildNodeRefList()
 
         # check for the dang city book and do stuff
@@ -1457,7 +1457,7 @@ def IUpdateLinks(self):
                             break
 
         ageVault = ptAgeVault()
-        PAL = ageVault.getAgesIOwnFolder()
+        PAL = ageVault.getBookshelfFolder()
         if PAL is not None:
             contents = PAL.getChildNodeRefList()
 
@@ -1970,7 +1970,7 @@ def HasCityBook(self):
 
     def GetOwnedAgeLink(self, age):
         vault = ptAgeVault()
-        PAL = vault.getAgesIOwnFolder()
+        PAL = vault.getBookshelfFolder()
         if PAL is not None:
             contents = PAL.getChildNodeRefList()
             for content in contents:

Scripts/Python/xLinkingBookGUIPopup.py

@@ -736,7 +736,7 @@ def BuildCityBook(self):
 
         # citybook links have been changed to Hood childages, so we search there now
         #vault = ptAgeVault()
-        #OwnedAges = vault.getAgesIOwnFolder().getChildNodeRefList()
+        #OwnedAges = vault.getBookshelfFolder().getChildNodeRefList()
         childAgeFolder = self.IGetHoodInfoNode().getChildAgesFolder()
         HoodChildAges = childAgeFolder.getChildNodeRefList()
         spawnPoints = []
@@ -878,7 +878,7 @@ def BuildTreasureLinks(self,ageRequested):
 
         # Step 1: Find this age's spawnPoints
         vault = ptAgeVault()
-        OwnedAges = vault.getAgesIOwnFolder().getChildNodeRefList()
+        OwnedAges = vault.getBookshelfFolder().getChildNodeRefList()
         spawnPoints = None
         for NodeRef in OwnedAges:
             tmpLink = NodeRef.getChild().upcastToAgeLinkNode()
@@ -1016,7 +1016,7 @@ def OnTimer(self,id):
 
     def GetOwnedAgeLink(self, age):
         vault = ptAgeVault()
-        PAL = vault.getAgesIOwnFolder()
+        PAL = vault.getBookshelfFolder()
         if PAL is not None:
             contents = PAL.getChildNodeRefList()
             for content in contents:

Sources/Plasma/FeatureLib/pfPython/pyAgeVaultGlue.cpp

@@ -79,11 +79,6 @@ PYTHON_METHOD_DEFINITION_NOARGS(ptAgeVault, getChronicleFolder)
     return self->fThis->GetChronicleFolder();
 }
 
-PYTHON_METHOD_DEFINITION_NOARGS(ptAgeVault, getAgesIOwnFolder)
-{
-    return self->fThis->GetBookshelfFolder();
-}
-
 PYTHON_METHOD_DEFINITION_NOARGS(ptAgeVault, getBookshelfFolder)
 {
     return self->fThis->GetBookshelfFolder();
@@ -248,7 +243,6 @@ PYTHON_START_METHODS_TABLE(ptAgeVault)
     PYTHON_METHOD_NOARGS(ptAgeVault, getAgeDevicesFolder, "Returns a ptVaultFolderNode of the inboxes for the devices in this Age."),
     PYTHON_METHOD_NOARGS(ptAgeVault, getSubAgesFolder, "Returns a ptVaultFolderNode of sub Age's folder."),
     PYTHON_METHOD_NOARGS(ptAgeVault, getChronicleFolder, "Returns a ptVaultFolderNode"),
-    PYTHON_METHOD_NOARGS(ptAgeVault, getAgesIOwnFolder, "(depreciated, use getBookshelfFolder) Returns a ptVaultFolderNode that contain the Ages I own"),
     PYTHON_METHOD_NOARGS(ptAgeVault, getBookshelfFolder, "Personal age only: Returns a ptVaultFolderNode that contains the owning player's AgesIOwn age list"),
     PYTHON_METHOD_NOARGS(ptAgeVault, getPeopleIKnowAboutFolder, "Returns a ptVaultPlayerInfoListNode of the players the Age knows about(?)."),
     PYTHON_METHOD_NOARGS(ptAgeVault, getPublicAgesFolder, "Returns a ptVaultFolderNode that contains all the public Ages"),