Skip to content

Deployment: Fix Verify Code Signature in Windows Deployment #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
casaout opened this issue Feb 4, 2025 · 0 comments
Open

Deployment: Fix Verify Code Signature in Windows Deployment #373

casaout opened this issue Feb 4, 2025 · 0 comments
Labels
enhancement

Comments

@casaout
Copy link
Member

casaout commented Feb 4, 2025

For #350, we had to temporarily disable the update code signature verification (verifyUpdateCodeSignature: false).

When the flag is enabled, the update fails with the following error:

(AutoUpdater) Error in autoUpdater: Error: New version 0.0.35 is not signed by the application owner: publisherNames: , raw info: {
"SignerCertificate": {
"FriendlyName": "",

We need to figure out why it happens:

  • Do we somewhere need to explicitly set the publisherNames? (note that setting "publisherName" inside "win" doesn't work anymore)
  • Do we need to override the verify signature method?

Possible hints:
casaout added a commit that referenced this issue Feb 4, 2025
@casaout
[#373] disabled verify update code signature on windows
a19b804
casaout added a commit that referenced this issue Feb 4, 2025
@casaout @SRichner
Merge Main to Dev (after adding Windows Code Signing) (#374)
d979a10 
* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>
casaout added a commit that referenced this issue Feb 4, 2025
@casaout @SRichner
[#366] Clarify the app is running (#378)
653c367 
* Merge Main to Dev (after adding Windows Code Signing) (#374)

* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>

* fixed GH secrets info

* 366 clarify app is running (#375) and windows code signing (#350)

This comprises:
- refining context menu items
- showing PA is running in tasktray
- windows code signing 
- shows onboarding screen upon *manual* app launch
- bugfix related to macOS auto-updater (intel vs apple silicon feed url)

* [#366] test changes in release (0.0.37)

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>
casaout added a commit that referenced this issue Feb 11, 2025
@casaout @SRichner
testing something in CI release (0.0.38) (#383)
169b9d1 
* Merge Main to Dev (after adding Windows Code Signing) (#374)

* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>

* fixed GH secrets info

* 366 clarify app is running (#375) and windows code signing (#350)

This comprises:
- refining context menu items
- showing PA is running in tasktray
- windows code signing 
- shows onboarding screen upon *manual* app launch
- bugfix related to macOS auto-updater (intel vs apple silicon feed url)

* [#366] test changes in release (0.0.37)

* fixed links in readme

* [#376] adjust file logging to only log 'silly' on debug (#377)

* [#376] adjust file logging to only log 'silly' on debug

* [#376] moved is-dev check to other file (suggested by @royru)

* testing something in CI release (0.0.38)

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>
casaout added a commit that referenced this issue Feb 18, 2025
@casaout @SRichner @royru
v0.0.38 (#385)
1d2389e 
* Merge Main to Dev (after adding Windows Code Signing) (#374)

* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>

* fixed GH secrets info

* 366 clarify app is running (#375) and windows code signing (#350)

This comprises:
- refining context menu items
- showing PA is running in tasktray
- windows code signing 
- shows onboarding screen upon *manual* app launch
- bugfix related to macOS auto-updater (intel vs apple silicon feed url)

* [#366] test changes in release (0.0.37)

* fixed links in readme

* [#376] adjust file logging to only log 'silly' on debug (#377)

* [#376] adjust file logging to only log 'silly' on debug

* [#376] moved is-dev check to other file (suggested by @royru)

* testing something in CI release (0.0.38)

* added link to GH access token

* fixed link to GH access token

* Settings / Work Hours / Data Export Warning / Days Participated (#379)

* initial commit

* fixes colorpicker in PA.SelfReflection

* basic workschedule backend

* work hours front-end within `Settings` page

* `config.displayDaysParticipated` implemented

* show warning when data export win is closed before export completion

* remove README

* remove vscode setting

* tray menu improvements

* exclude experience sampling entries in for "days participated" if disabled

* `taskTracker` optional

* fixing log outputs

* update research.md

* fix data export warning dialog on Windows

* fix visibility of "Open Task Planning"

* fixing `dataExportWindow` getting destroyed prematurely

* documentation for "work hours" feature

* small design/text updates

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>
Co-authored-by: Roy <roy.rutishauser@uzh.ch>
casaout added a commit that referenced this issue Feb 18, 2025
@casaout @SRichner @royru
v0.0.38 (attempt 2) (#389)
c232193 
* Merge Main to Dev (after adding Windows Code Signing) (#374)

* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>

* fixed GH secrets info

* 366 clarify app is running (#375) and windows code signing (#350)

This comprises:
- refining context menu items
- showing PA is running in tasktray
- windows code signing 
- shows onboarding screen upon *manual* app launch
- bugfix related to macOS auto-updater (intel vs apple silicon feed url)

* [#366] test changes in release (0.0.37)

* fixed links in readme

* [#376] adjust file logging to only log 'silly' on debug (#377)

* [#376] adjust file logging to only log 'silly' on debug

* [#376] moved is-dev check to other file (suggested by @royru)

* testing something in CI release (0.0.38)

* added link to GH access token

* fixed link to GH access token

* Settings / Work Hours / Data Export Warning / Days Participated (#379)

* initial commit

* fixes colorpicker in PA.SelfReflection

* basic workschedule backend

* work hours front-end within `Settings` page

* `config.displayDaysParticipated` implemented

* show warning when data export win is closed before export completion

* remove README

* remove vscode setting

* tray menu improvements

* exclude experience sampling entries in for "days participated" if disabled

* `taskTracker` optional

* fixing log outputs

* update research.md

* fix data export warning dialog on Windows

* fix visibility of "Open Task Planning"

* fixing `dataExportWindow` getting destroyed prematurely

* documentation for "work hours" feature

* small design/text updates

* updating package-lock.json (#388)

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>
Co-authored-by: Roy <roy.rutishauser@uzh.ch>
casaout added a commit that referenced this issue Feb 20, 2025
@casaout @royru
Release v0.0.38 (#392)
5e49b89 
* Merge Main to Dev (after adding Windows Code Signing) (#374)

* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>

* fixed GH secrets info

* 366 clarify app is running (#375) and windows code signing (#350)

This comprises:
- refining context menu items
- showing PA is running in tasktray
- windows code signing 
- shows onboarding screen upon *manual* app launch
- bugfix related to macOS auto-updater (intel vs apple silicon feed url)

* [#366] test changes in release (0.0.37)

* fixed links in readme

* [#376] adjust file logging to only log 'silly' on debug (#377)

* [#376] adjust file logging to only log 'silly' on debug

* [#376] moved is-dev check to other file (suggested by @royru)

* testing something in CI release (0.0.38)

* added link to GH access token

* fixed link to GH access token

* Settings / Work Hours / Data Export Warning / Days Participated (#379)

* initial commit

* fixes colorpicker in PA.SelfReflection

* basic workschedule backend

* work hours front-end within `Settings` page

* `config.displayDaysParticipated` implemented

* show warning when data export win is closed before export completion

* remove README

* remove vscode setting

* tray menu improvements

* exclude experience sampling entries in for "days participated" if disabled

* `taskTracker` optional

* fixing log outputs

* update research.md

* fix data export warning dialog on Windows

* fix visibility of "Open Task Planning"

* fixing `dataExportWindow` getting destroyed prematurely

* documentation for "work hours" feature

* small design/text updates

* updating package-lock.json (#388)

* reverted changes of the airbar stub

* revert formatting changes

---------

Co-authored-by: Roy <roy.rutishauser@uzh.ch>
Co-authored-by: royru <roy.rutishauser@gmail.com>
@casaout casaout mentioned this issue Feb 20, 2025
Merged
casaout added a commit that referenced this issue Feb 23, 2025
@royru @casaout @SRichner
366 clarify app is running (#394)
743fed0 
* Merge Main to Dev (after adding Windows Code Signing) (#374)

* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>

* fixed GH secrets info

* [#366] showing PA when clicking the app icon

+ refining context menu items
+ showing PA is running in tasktray

* [#366] refined context menu

* [#366] showing onboarding window on manual app start

* [#366] fix bug to open last page of onboarding on macOS

* Revert "[#366] fix bug to open last page of onboarding on macOS"

This reverts commit d487ddd.

* trying to fix manual app start onboarding step

* build + publish batch

* unrelated: leftover airbar config

* [#366] updated logic for showing onboarding window on manual app start

* [#366] fixed bug (thanks @royru)

---------

Co-authored-by: André Meyer <casaout@users.noreply.github.com>
Co-authored-by: Sebastian Richner <sebastian@richner.ag>
Co-authored-by: André Meyer <info@andre-meyer.ch>
casaout added a commit that referenced this issue Feb 24, 2025
@casaout @SRichner
@SWELL-PA-DEV @royru
Release v0.0.39 (#398)
3b98823 
* Merge Main to Dev (after adding Windows Code Signing) (#374)

* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>

* fixed GH secrets info

* 366 clarify app is running (#375) and windows code signing (#350)

This comprises:
- refining context menu items
- showing PA is running in tasktray
- windows code signing 
- shows onboarding screen upon *manual* app launch
- bugfix related to macOS auto-updater (intel vs apple silicon feed url)

* [#366] test changes in release (0.0.37)

* fixed links in readme

* [#376] adjust file logging to only log 'silly' on debug (#377)

* [#376] adjust file logging to only log 'silly' on debug

* [#376] moved is-dev check to other file (suggested by @royru)

* testing something in CI release (0.0.38)

* added link to GH access token

* fixed link to GH access token

* initial changes to SWELL-deployment

* testing release (0.2.41)

* testing v0.2.42 release

* fixed repo

* testing auto-updater (v0.2.43)

* Several minor improvements to UI/styling

* re-enabling that data export is enabled by default

* Revert "Merge branch 'dev' into dev"

This reverts commit f290254, reversing
changes made to bdeacb0.

* 366 clarify app is running (#394)

* Merge Main to Dev (after adding Windows Code Signing) (#374)

* [#350] attempting windows code signing

* [#350] updating electron-builder

* [#350] trying newer version of electron builder

* [#350] fixing notarize

* [#350] fixing macos notarization attempt 2

* [#350] testing auto-update for code-signed win version

* [#350] updated electron-updater

* [#350] testing auto-update on windows

* [#350] added explicit publisherName for Windows, updated signing docu

* [#350] version bump to trigger build

* [#350] trying updater without verification

* [#350] another try

* [#350] attempting to fix macOS updater

* [#350] trigger update to 0.0.32

* [#350] trying to fix macos build

* [#350] trying to fix macOS build

* [#350] trying to fix update code signature verification on windows

* [#350] trying to fix update code signature verification on windows (v0.0.35)

* [#350] trying to fix update code signature verification on windows

* [#350] removing publisherName tag again (no longer supported)

* [#373] disabled verify update code signature on windows

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>

* fixed GH secrets info

* [#366] showing PA when clicking the app icon

+ refining context menu items
+ showing PA is running in tasktray

* [#366] refined context menu

* [#366] showing onboarding window on manual app start

* [#366] fix bug to open last page of onboarding on macOS

* Revert "[#366] fix bug to open last page of onboarding on macOS"

This reverts commit d487ddd.

* trying to fix manual app start onboarding step

* build + publish batch

* unrelated: leftover airbar config

* [#366] updated logic for showing onboarding window on manual app start

* [#366] fixed bug (thanks @royru)

---------

Co-authored-by: André Meyer <casaout@users.noreply.github.com>
Co-authored-by: Sebastian Richner <sebastian@richner.ag>
Co-authored-by: André Meyer <info@andre-meyer.ch>

* bugfix: experience sampling outside work hours (#397)

* trying to fix the bug

* improve comments

* version bump for v0.0.39 release

---------

Co-authored-by: Sebastian Richner <sebastian@richner.ag>
Co-authored-by: SWELL-PA-DEV <swell-dev@d2usp.ch>
Co-authored-by: Roy <roy.rutishauser@uzh.ch>
@casaout casaout mentioned this issue Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@casaout