Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

There is a bug in the _classes.py file #20

Open
wenzhong2005 opened this issue Jan 11, 2023 · 0 comments
Open

There is a bug in the _classes.py file #20

wenzhong2005 opened this issue Jan 11, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@wenzhong2005
Copy link

Describe the bug
In the file: https://github.com/Ibotta/pure-predict/blob/master/pure_sklearn/tree/_classes.py#L37

Line# 37:
It seems that "[-1]" at the end is not needed. Otherwise, there will be issues if there are 10 variables or more.

To Reproduce
Create a data set with more than 9 variables.

Expected behavior
Variable names fmn will not return mn, but return n only.

Additional context

@wenzhong2005 wenzhong2005 added the bug Something isn't working label Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants