BuiltinValue: insertCoin and unionValue and scaleValue costing #7384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ana-pantilie
force-pushed
the
ana/value-costing
branch
from
a62c427 to
85884d2
Compare
zliu41
changed the title
Member
|
@basetunnel you can work on costing scaleValue. |
ana-pantilie
force-pushed
the
ana/value-costing
branch
from
65d6c9e to
52d9d21
Compare
zliu41
reviewed
Nov 6, 2025
|
|
||
| -- | Generate a unique PolicyId on a uniform distribution. Note that the size of the | ||
| -- generated bytestring is going to be larger than Value.maxKeyLen, because we | ||
| -- append a counter integer to ensure uniqueness. This is acceptable for benchmarking |
Member
There was a problem hiding this comment.
Doesn't it make insertCoin fail? It enforces key lengths.
| -- purposes, as we're interested in the worst-case performance. | ||
| newPolicyId :: StateGenM StdGen -> BenchState PolicyId | ||
| newPolicyId gen = do | ||
| bs <- uniformByteStringM Value.maxKeyLen gen |
Member
There was a problem hiding this comment.
It's better to fix the first 30 bytes, and randomize the last 2 bytes. That aligns better with worst case. I think that's what Yura's generator does, so you can probably reuse that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/IntersectMBO/plutus-private/issues/1899
Pre-submit checklist: