Equivalent of Unity's FindGameObjectsWithTag and refactoring

Do not update if you're using Tags for editor

Author: IntoTheDev

Runtime/Tag.cs

@@ -15,16 +15,46 @@ public sealed class Tag : ScriptableObject
 #if ODIN_INSPECTOR
 		[ShowInInspector, ReadOnly]
 #endif
-		private HashSet<int> _entities = new HashSet<int>();
+		private readonly HashSet<int> _instancesHash = new HashSet<int>();
+		private readonly List<GameObject> _instances = new List<GameObject>(128);
 
-		public void Add(int entity) =>
-			_entities.Add(entity);
+		public void Add(GameObject instance)
+		{
+			int hash = instance.GetHashCode();
 
-		public void Remove(int entity) =>
-			_entities.Remove(entity);
+			if (!_instancesHash.Contains(hash))
+			{
+				_instances.Add(instance);
+				_instancesHash.Add(hash);
+			}
+		}
 
-		public bool HasEntity(int entity) =>
-			_entities.Contains(entity);
+		public void Remove(GameObject instance)
+		{
+			int hash = instance.GetHashCode();
+
+			if (_instancesHash.Contains(hash))
+			{
+				_instances.Remove(instance);
+				_instancesHash.Remove(hash);
+			}
+		}
+
+		public bool HasInstance(int instanceHash) =>
+			_instancesHash.Contains(instanceHash);
+
+		public IReadOnlyList<GameObject> GetInstances()
+		{
+			for (int i = _instances.Count - 1; i >= 0; i--)
+			{
+				var instance = _instances[i];
+
+				if (instance == null)
+					_instances.RemoveAt(i);
+			}
+
+			return _instances.AsReadOnly();
+		}
 	}
 }
 

Runtime/Tag.cs.meta

@@ -4,105 +4,48 @@ namespace ToolBox.Tags
 {
 	public static class TagExtensions
 	{
-		public static void AddTag(this GameObject entity, Tag tag)
-		{
-#if UNITY_EDITOR
-			var taggable = entity.GetComponent<Taggable>();
-
-			if (taggable == null)
-				taggable = entity.AddComponent<Taggable>();
-
-			taggable.AddTagInEditor(tag);
-#endif
-
-			tag.Add(entity.GetHashCode());
-		}
-
-		public static void RemoveTag(this GameObject entity, Tag tag)
-		{
-#if UNITY_EDITOR
-			var taggable = entity.GetComponent<Taggable>();
-
-			if (taggable == null)
-				taggable = entity.AddComponent<Taggable>();
-
-			taggable.RemoveTagInEditor(tag);
-#endif
+		public static void AddTag(this GameObject instance, Tag tag) =>
+			tag.Add(instance);
 
-			tag.Remove(entity.GetHashCode());
-		}
+		public static void RemoveTag(this GameObject instance, Tag tag) =>
+			tag.Remove(instance);
 
 		public static bool HasTag(this GameObject entity, Tag tag) =>
-			tag.HasEntity(entity.GetHashCode());
+			tag.HasInstance(entity.GetHashCode());
 
-		public static void AddTags(this GameObject entity, Tag[] tags)
+		public static void AddTags(this GameObject instance, Tag[] tags)
 		{
-			int hash = entity.GetHashCode();
-#if UNITY_EDITOR
-			var taggable = entity.GetComponent<Taggable>();
-
-			if (taggable == null)
-				taggable = entity.AddComponent<Taggable>();
-#endif
-
 			for (int i = 0; i < tags.Length; i++)
-			{
-				var tag = tags[i];
-				tag.Add(hash);
-#if UNITY_EDITOR
-				taggable.AddTagInEditor(tag);
-#endif
-			}
+				tags[i].Add(instance);
 		}
 
-		public static void RemoveTags(this GameObject entity, Tag[] tags)
-		{
-			int hash = entity.GetHashCode();
-#if UNITY_EDITOR
-			var taggable = entity.GetComponent<Taggable>();
-
-			if (taggable == null)
-				taggable = entity.AddComponent<Taggable>();
-#endif
+		public static void AddTags(this GameObject instance, TagsContainer container) =>
+			container.Add(instance);
 
+		public static void RemoveTags(this GameObject instance, Tag[] tags)
+		{
 			for (int i = 0; i < tags.Length; i++)
-			{
-				var tag = tags[i];
-				tag.Remove(hash);
-#if UNITY_EDITOR
-				taggable.RemoveTagInEditor(tag);
-#endif
-			}
+				tags[i].Remove(instance);
 		}
 
-		public static bool HasTags(this GameObject entity, Tag[] tags, bool allRequired)
+		public static void RemoveTags(this GameObject instance, TagsContainer container) =>
+			container.Remove(instance);
+
+		public static bool HasTags(this GameObject instance, Tag[] tags, bool allRequired)
 		{
-			int hash = entity.GetHashCode();
+			int hash = instance.GetHashCode();
 
-			if (allRequired)
+			for (int i = 0; i < tags.Length; i++)
 			{
-				for (int i = 0; i < tags.Length; i++)
-				{
-					if (!tags[i].HasEntity(hash))
-						return false;
-				}
-
-				return true;
+				if (tags[i].HasInstance(hash) == !allRequired)
+					return !allRequired;
 			}
-			else
-			{
-				for (int i = 0; i < tags.Length; i++)
-				{
-					if (tags[i].HasEntity(hash))
-						return true;
-				}
 
-				return false;
-			}
+			return allRequired;
 		}
 
-		public static bool HasTags(this GameObject entity, TagsContainer tagsContainer, bool allRequired) =>
-			tagsContainer.HasEntity(entity, allRequired);
+		public static bool HasTags(this GameObject instance, TagsContainer container, bool allRequired) =>
+			container.HasInstance(instance, allRequired);
 	}
 }
 

Runtime/TagExtensions.cs

@@ -1,112 +1,28 @@
 #if ODIN_INSPECTOR
 using Sirenix.OdinInspector;
 #endif
-#if UNITY_EDITOR
-using UnityEditor;
-#endif
 using UnityEngine;
 
 namespace ToolBox.Tags
 {
-	[DisallowMultipleComponent, DefaultExecutionOrder(-9000), ExecuteInEditMode]
+	[DisallowMultipleComponent, DefaultExecutionOrder(-9000)]
 	public sealed class Taggable : MonoBehaviour
 	{
 #if ODIN_INSPECTOR
 		[Required, AssetList]
 #endif
 		[SerializeField] private Tag[] _tags = default;
 
-#if UNITY_EDITOR
-		private static Tag[] _all = null;
-#endif
-		private int _hash = 0;
+		private GameObject _instance = null;
 
 		private void Awake()
 		{
-#if UNITY_EDITOR
-			SetupEditorData();
-#endif
-
-			_hash = gameObject.GetHashCode();
-			AddAll();
+			_instance = gameObject;
+			_instance.AddTags(_tags);
 		}
 
 		private void OnDestroy() =>
-			RemoveAll();
-
-		private void AddAll()
-		{
-			for (int i = 0; i < _tags.Length; i++)
-				_tags[i].Add(_hash);
-		}
-
-		private void RemoveAll()
-		{
-			for (int i = 0; i < _tags.Length; i++)
-				_tags[i].Remove(_hash);
-		}
-
-#if UNITY_EDITOR
-		public void AddTagInEditor(Tag tag)
-		{
-			if (!ArrayUtility.Contains(_tags, tag))
-				ArrayUtility.Add(ref _tags, tag);
-		}
-
-		public void RemoveTagInEditor(Tag tag)
-		{
-			if (ArrayUtility.Contains(_tags, tag))
-				ArrayUtility.Remove(ref _tags, tag);
-		}
-
-		// Handle Inspector Changes
-		private void OnValidate()
-		{
-			SetupEditorData();
-			var obj = gameObject;
-			AddAll();
-
-			for (int i = 0; i < _all.Length; i++)
-			{
-				var tag = _all[i];
-
-				if (ArrayUtility.Contains(_tags, tag))
-				{
-					if (!obj.HasTag(tag))
-						obj.AddTag(tag);
-				}
-				else
-				{
-					if (obj.HasTag(tag))
-						obj.RemoveTag(tag);
-				}
-			}
-		}
-
-		private void SetupEditorData()
-		{
-			if (_all == null)
-				_all = Resources.FindObjectsOfTypeAll<Tag>();
-
-			if (_tags == null)
-			{
-				_tags = new Tag[0];
-			}
-			else
-			{
-				for (int i = _tags.Length - 1; i >= 0; i--)
-				{
-					var tag = _tags[i];
-
-					if (tag == null)
-						ArrayUtility.RemoveAt(ref _tags, i);
-				}
-			}
-
-			if (_hash == 0)
-				_hash = gameObject.GetHashCode();
-		}
-#endif
+			_instance.RemoveTags(_tags);
 	}
 }
 

Runtime/TagExtensions.cs.meta

@@ -13,8 +13,20 @@ public sealed class TagsContainer : ScriptableObject
 	{
 		[SerializeField] private Tag[] _tags = null;
 
-		public bool HasEntity(GameObject entity, bool allRequired) =>
-			entity.HasTags(_tags, allRequired);
+		public void Add(GameObject instance)
+		{
+			for (int i = 0; i < _tags.Length; i++)
+				_tags[i].Add(instance);
+		}
+
+		public void Remove(GameObject instance)
+		{
+			for (int i = 0; i < _tags.Length; i++)
+				_tags[i].Remove(instance);
+		}
+
+		public bool HasInstance(GameObject instance, bool allRequired) =>
+			instance.HasTags(_tags, allRequired);
 	}
 }