Skip to content

Commit 27c8ddd

Browse files
committed
Use LieGroups.TranslationGroup
1 parent 3862daf commit 27c8ddd

File tree

12 files changed

+18
-10
lines changed

12 files changed

+18
-10
lines changed

IncrementalInference/src/Factors/EuclidDistance.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ getDimension(::InstanceType{<:EuclidDistance}) = 1
2020
(s::CalcFactor{<:EuclidDistance})(z, x1, x2) = z .- norm(x2 .- x1)
2121

2222
function Base.convert(::Type{<:MB.AbstractManifold}, ::InstanceType{EuclidDistance})
23-
return Manifolds.TranslationGroup(1)
23+
return LieGroups.TranslationGroup(1)
2424
end
2525

2626
"""

IncrementalInference/src/Factors/LinearRelative.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function Base.convert(
5252
::Type{<:MB.AbstractManifold},
5353
::InstanceType{LinearRelative{N}},
5454
) where {N}
55-
return Manifolds.TranslationGroup(N)
55+
return LieGroups.TranslationGroup(N)
5656
end
5757

5858
"""

IncrementalInference/src/IncrementalInference.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ using ManifoldsBase: ℝ, AbstractManifold, AbstractBasis, TypeParameter, Abstra
2020

2121
import LieGroups
2222
using LieGroups: LieGroup, LieAlgebra, ProductLieGroup, hat, vee, compose, AbstractProductGroupOperation, AdditionGroupOperation, SpecialEuclideanGroup, SpecialOrthogonalGroup
23+
using LieGroups: TranslationGroup
2324
# using LieGroups: ProductGroupOperation, SemiDirectProductGroupOperation
2425

2526
using RecursiveArrayTools: ArrayPartition

IncrementalInference/src/Serialization/services/SerializationMKD.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# relies on later use of getManifold to give back the same <:AbstractManifold
66
# NOTE added to DFG.@defVariable
77
getVariableType(M::Euclidean{TypeParameter{Tuple{N}}}) where {N} = ContinuousEuclid(N)
8-
getVariableType(M::Manifolds.TranslationGroup{TypeParameter{Tuple{N}}}) where {N} = ContinuousEuclid(N)
8+
getVariableType(M::LieGroups.TranslationGroup{TypeParameter{Tuple{N}}}) where {N} = ContinuousEuclid(N)
99

1010
# getVariableType(M::RealCircleGroup) = Circular()
1111
# getVariableType(M::Circle) = error("Circle manifold is deprecated use RealCircleGroup, will come back when we generalize to non-group Riemannian")

IncrementalInference/src/manifolds/services/ManifoldsExtentions.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ function DFG.getPointIdentity(
161161
end
162162

163163
function DFG.getPointIdentity(
164-
G::Manifolds.TranslationGroup{TypeParameter{Tuple{N}}},
164+
G::LieGroups.TranslationGroup{TypeParameter{Tuple{N}}},
165165
::Type{T} = Float64,
166166
) where {N, T <: Real}
167167
return zeros(SVector{N, T})

IncrementalInference/src/services/SolverAPI.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ function solveTree!(
387387

388388
# perhaps duplicate current value
389389
if storeOld || opt.dbg
390-
ss = listSupersolves(dfgl) .|> string
390+
ss = listSolveKeys(dfgl) .|> string
391391
ss_ = ss[occursin.(r"default_", ss)] .|> x -> x[9:end]
392392
filter!(x -> occursin(r"^\d+$", x), ss_) # ss_ = ss_[occursin.(r"^\d$",ss_)]
393393
allk = parse.(Int, ss_)

IncrementalInference/test/runtests.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
using Test
22

3+
# TODO remove, forcing conflict to use LieGroups
4+
using LieGroups: TranslationGroup
5+
36
TEST_GROUP = get(ENV, "IIF_TEST_GROUP", "all")
47

58
# temporarily moved to start (for debugging)

IncrementalInferenceTypes/Project.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"
99
DistributedFactorGraphs = "b5cc3c7e-6572-11e9-2517-99fb8daf2f04"
1010
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
1111
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
12+
LieGroups = "6774de46-80ba-43f8-ba42-e41071ccfc5f"
1213
Manifolds = "1cead3c2-87b3-11e9-0ccd-23c62b72b94e"
1314
RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
1415
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
@@ -20,6 +21,7 @@ Distributed = "1.10.0"
2021
DistributedFactorGraphs = "0.27.0"
2122
Distributions = "0.25.120"
2223
DocStringExtensions = "0.9.5"
24+
LieGroups = "0.1.2"
2325
Manifolds = "0.10.16"
2426
RecursiveArrayTools = "3.33.0"
2527
StaticArrays = "1.9.13"

IncrementalInferenceTypes/src/IncrementalInferenceTypes.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ module IncrementalInferenceTypes
22

33
using DistributedFactorGraphs
44
using DocStringExtensions
5-
using Manifolds
5+
import Manifolds
6+
using LieGroups
7+
using LieGroups: TranslationGroup
68
using Distributions
79
using StaticArrays
810
import StructTypes

IncrementalInferenceTypes/src/factors/DefaultPrior.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ not recommended when non-Euclidean dimensions are used in variables.
77
struct Prior{T} <: AbstractPrior
88
Z::T
99
end
10-
DFG.getManifold(pr::Prior) = TranslationGroup(getDimension(pr.Z))
10+
DFG.getManifold(pr::Prior) = LieGroups.TranslationGroup(getDimension(pr.Z))
1111

1212
"""
1313
$(TYPEDEF)

0 commit comments

Comments
 (0)