no kwarg and inline

Author: chriselrod

Project.toml

@@ -1,7 +1,7 @@
 name = "Polyester"
 uuid = "f517fe37-dbe3-4b94-8317-1923a5111588"
 authors = ["Chris Elrod <elrodc@gmail.com> and contributors"]
-version = "0.6.10"
+version = "0.6.11"
 
 [deps]
 ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"

src/batch.jl

@@ -110,14 +110,14 @@ function add_var!(q, argtup, gcpres, ::Type{T}, argtupname, gcpresname, k) where
 end
 @generated function _batch_no_reserve(
   f!::F,
+  threadlocal::Val{thread_local},
   threadmask_tuple::NTuple{N},
   nthread_tuple,
   torelease_tuple,
   Nr,
   Nd,
   ulen,
-  args::Vararg{Any,K};
-  threadlocal::Val{thread_local} = Val(false),
+  args::Vararg{Any,K},
 ) where {F,K,N,thread_local}
   q = quote
     $(Expr(:meta, :inline))
@@ -282,12 +282,19 @@ end
 #   q
 # end
 
+@inline function batch(
+  f!::F,
+  (len, nbatches)::Tuple{Vararg{Integer,2}},
+  args::Vararg{Any,K}) where {F,K}
+
+  batch(f!, Val{false}(), (len, nbatches), args...)
+end
 
 @inline function batch(
   f!::F,
+  threadlocal::Val{thread_local},
   (len, nbatches)::Tuple{Vararg{Integer,2}},
-  args::Vararg{Any,K};
-  threadlocal::Val{thread_local} = Val{false}(),
+  args::Vararg{Any,K}
 ) where {F,K,thread_local}
   # threads, torelease = request_threads(Base.Threads.threadid(), nbatches - one(nbatches))
   len > 0 || return
@@ -310,14 +317,14 @@ end
   Nr = ulen - Nd * nbatch
   _batch_no_reserve(
     f!,
+    threadlocal,
     map(mask, threads),
     nthreads,
     torelease,
     Nr,
     Nd,
     ulen,
-    args...;
-    threadlocal,
+    args...
   )
 end
 function batch(

src/closure.jl

@@ -387,21 +387,31 @@ function enclose(
     end
   end
   push!(q.args, esc(closureq))
-  batchcall = Expr(
-    :call,
-    batch,
-    esc(closure),
-    threadtup,
-    Symbol("##LOOPOFFSET##"),
-    Symbol("##LOOP_STEP##"),
-  )
+  batchcall = if threadlocal !== Symbol("")
+    Expr(
+      :call,
+      batch,
+      esc(closure),
+      Val(true),
+      threadtup,
+      Symbol("##LOOPOFFSET##"),
+      Symbol("##LOOP_STEP##"),
+    )
+  else
+    Expr(
+      :call,
+      batch,
+      esc(closure),
+      Val(false),
+      threadtup,
+      Symbol("##LOOPOFFSET##"),
+      Symbol("##LOOP_STEP##"),
+    )
+  end
   for a ∈ arguments
     push!(args.args, get(defined, a, a))
     push!(batchcall.args, esc(a))
   end
-  if threadlocal !== Symbol("")
-    push!(batchcall.args, Expr(:kw, :threadlocal, Val(true)))
-  end
   push!(q.args, batchcall)
   quote
     if $num_threads() == 1