Fix: Account details saved only after successful game launch #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the account-saving logic in `src/onelauncher/main_window.py` to after the game has been launched. This prevents the `last_used_world_name` from being updated if the game launch is canceled or fails. Also includes a fix for a Python 3.12 compatibility issue in `src/onelauncher/utilities.py`.
Fix: Account details saved only after successful game launch
Owner
That info is purposefully saved after the account is authenticated but before the game is launched. Can you let me know your reasoning for why you want different behavior?
Python 3.12 support requires quite a bit more work than that. Thanks for the thought, though. I'd also appreciate it if in the future, you can avoid using AI for PRs or at the very least thoroughly review the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the account-saving logic in
src/onelauncher/main_window.pyto after the game has been launched. This prevents thelast_used_world_namefrom being updated if the game launch is canceled or fails.Also includes a fix for a Python 3.12 compatibility issue in
src/onelauncher/utilities.py.