Skip to content

Commit e58b7ba

Browse files
Jungwoo-AnJungwoo-An
authored
feat: Improve typings (#196)
1 parent f5d4731 commit e58b7ba

File tree

9 files changed

+19
-33
lines changed

9 files changed

+19
-33
lines changed

‎.pnp.cjs

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.yarn/install-state.gz

-917 Bytes
Binary file not shown.

‎packages/@react-editor-js/client/src/ReactEditorJSClient.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
import React from 'react'
2-
import {
3-
Props as ReactEditorJSProps,
4-
ReactEditorJS,
5-
} from '@react-editor-js/core'
2+
import { WrapperProps as Props, ReactEditorJS } from '@react-editor-js/core'
63

74
import { ClientEditorCore } from './client-editor-core'
85
import { EditorConfig } from '@editorjs/editorjs'
96

10-
export type Props = Omit<ReactEditorJSProps, 'factory'>
11-
127
function ReactEditorJSClient(props: Props) {
138
const factory = React.useCallback(
149
(config: EditorConfig) => new ClientEditorCore(config),

‎packages/@react-editor-js/core/src/component-types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,5 @@ export interface Props extends Omit<EditorConfig, 'data'> {
1414

1515
onInitialize?: (core: EditorCore) => void
1616
}
17+
18+
export type WrapperProps = Omit<Props, 'factory'>

‎packages/@react-editor-js/server/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"peerDependencies": {
1616
"@editorjs/editorjs": "*",
1717
"@editorjs/paragraph": "*",
18-
"@react-editor-js/core": "2.0.6",
1918
"react": "*"
2019
},
2120
"dependencies": {

‎packages/@react-editor-js/server/src/ReactEditorJSServer.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
import React from 'react'
2-
import {
3-
Props as ReactEditorJSProps,
4-
ReactEditorJS,
5-
} from '@react-editor-js/core'
2+
import { WrapperProps as Props, ReactEditorJS } from '@react-editor-js/core'
63
import { EditorConfig } from '@editorjs/editorjs'
74

85
import { ServerEditorCore } from './server-editor-core'
96

10-
export type Props = Omit<ReactEditorJSProps, 'factory'>
11-
127
function ReactEditorJSServer(props: Props) {
138
const factory = React.useCallback(
149
(config: EditorConfig) => new ServerEditorCore(config),

‎packages/react-editor-js/package.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,17 @@
44
"description": "The unofficial editor-js component for React",
55
"main": "./dist/react-editor-js.cjs.js",
66
"module": "./dist/react-editor-js.js",
7-
"types": "./dist/index.d.ts",
7+
"types": "./dist/react-editor-js/src/index.d.ts",
88
"repository": {
99
"type": "git",
1010
"url": "https://github.com/Jungwoo-An/react-editor-js.git"
1111
},
1212
"bugs": {
1313
"url": "https://github.com/Jungwoo-An/react-editor-js/issues"
1414
},
15-
"peerDependencies": {
16-
"@react-editor-js/client": "2.0.6",
17-
"@react-editor-js/server": "2.0.6"
18-
},
1915
"dependencies": {
2016
"@react-editor-js/client": "2.0.6",
17+
"@react-editor-js/core": "2.0.6",
2118
"@react-editor-js/server": "2.0.6"
2219
},
2320
"devDependencies": {

‎packages/react-editor-js/src/factory.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
export function createReactEditorJS() {
1+
import { WrapperProps } from '@react-editor-js/core'
2+
3+
export function createReactEditorJS(): (props: WrapperProps) => JSX.Element {
24
if (typeof window !== 'undefined') {
35
const Component = require('@react-editor-js/client')
46
return Component.default || Component

‎yarn.lock

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -821,13 +821,13 @@ __metadata:
821821
languageName: node
822822
linkType: hard
823823

824-
"@react-editor-js/client@2.0.5, @react-editor-js/client@workspace:packages/@react-editor-js/client":
824+
"@react-editor-js/client@2.0.6, @react-editor-js/client@workspace:packages/@react-editor-js/client":
825825
version: 0.0.0-use.local
826826
resolution: "@react-editor-js/client@workspace:packages/@react-editor-js/client"
827827
dependencies:
828828
"@editorjs/editorjs": "*"
829829
"@editorjs/paragraph": "*"
830-
"@react-editor-js/core": 2.0.5
830+
"@react-editor-js/core": 2.0.6
831831
"@types/react": "*"
832832
react: "*"
833833
tslib: ^2.3.1
@@ -839,7 +839,7 @@ __metadata:
839839
languageName: unknown
840840
linkType: soft
841841

842-
"@react-editor-js/core@2.0.5, @react-editor-js/core@workspace:packages/@react-editor-js/core":
842+
"@react-editor-js/core@2.0.6, @react-editor-js/core@workspace:packages/@react-editor-js/core":
843843
version: 0.0.0-use.local
844844
resolution: "@react-editor-js/core@workspace:packages/@react-editor-js/core"
845845
dependencies:
@@ -857,21 +857,20 @@ __metadata:
857857
languageName: unknown
858858
linkType: soft
859859

860-
"@react-editor-js/server@2.0.5, @react-editor-js/server@workspace:packages/@react-editor-js/server":
860+
"@react-editor-js/server@2.0.6, @react-editor-js/server@workspace:packages/@react-editor-js/server":
861861
version: 0.0.0-use.local
862862
resolution: "@react-editor-js/server@workspace:packages/@react-editor-js/server"
863863
dependencies:
864864
"@editorjs/editorjs": "*"
865865
"@editorjs/paragraph": "*"
866-
"@react-editor-js/core": 2.0.5
866+
"@react-editor-js/core": 2.0.6
867867
"@types/react": "*"
868868
react: "*"
869869
tslib: ^2.3.1
870870
typescript: ^4.3.5
871871
peerDependencies:
872872
"@editorjs/editorjs": "*"
873873
"@editorjs/paragraph": "*"
874-
"@react-editor-js/core": 2.0.5
875874
react: "*"
876875
languageName: unknown
877876
linkType: soft
@@ -5803,14 +5802,12 @@ __metadata:
58035802
version: 0.0.0-use.local
58045803
resolution: "react-editor-js@workspace:packages/react-editor-js"
58055804
dependencies:
5806-
"@react-editor-js/client": 2.0.5
5807-
"@react-editor-js/server": 2.0.5
5805+
"@react-editor-js/client": 2.0.6
5806+
"@react-editor-js/core": 2.0.6
5807+
"@react-editor-js/server": 2.0.6
58085808
"@types/node": ^16.11.6
58095809
tslib: ^2.3.1
58105810
typescript: ^4.3.5
5811-
peerDependencies:
5812-
"@react-editor-js/client": 2.0.5
5813-
"@react-editor-js/server": 2.0.5
58145811
languageName: unknown
58155812
linkType: soft
58165813

0 commit comments

Comments
 (0)