Skip to content

Commit 5caf5d3

Browse files
committed
printf
1 parent d4852a4 commit 5caf5d3

File tree

1 file changed

+27
-27
lines changed

1 file changed

+27
-27
lines changed

usr/bin/dummy-dependency

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ set -o nounset
1515
true "$0: INFO: START"
1616

1717
show_usage() {
18-
echo "Usage: $0 [--remove|--purge] [-y|--yes] 'package-name'" >&2
18+
printf '%s\n' "Usage: $0 [--remove|--purge] [-y|--yes] 'package-name'" >&2
1919
exit 1
2020
}
2121

@@ -27,7 +27,7 @@ cleanup() {
2727

2828
root_check() {
2929
if [ "$(id -u)" -ne 0 ]; then
30-
echo "$0: ERROR: This script must be run as root." >&2
30+
printf '%s\n' "$0: ERROR: This script must be run as root." >&2
3131
exit 1
3232
fi
3333
}
@@ -50,12 +50,12 @@ Architecture: all
5050
Description: dummy-package for '${package_to_replace}'
5151
A metapackage that replaces '${package_to_replace}'."
5252

53-
echo "${equivs_content}" | sponge -- "${equivs_file}"
53+
printf '%s\n' "${equivs_content}" | sponge -- "${equivs_file}"
5454

5555
if ! equivs_build_log="$(equivs-build -- "${equivs_file}" 2>&1)" ; then
56-
echo "$0: ERROR: 'equivs-build -- \"${equivs_file}\"' command failed!" >&2
57-
echo "$0: Logs:" >&2
58-
echo "${equivs_build_log}" >&2
56+
printf '%s\n' "$0: ERROR: 'equivs-build -- \"${equivs_file}\"' command failed!" >&2
57+
printf '%s\n' "$0: Logs:" >&2
58+
printf '%s\n' "${equivs_build_log}" >&2
5959
exit 1
6060
fi
6161

@@ -67,19 +67,19 @@ Description: dummy-package for '${package_to_replace}'
6767
## N: Download is performed unsandboxed as root as file '/tmp/user/0/tmp.8O7ET4e1Bx/dummy-user-sysmaint-split_99_all.deb' couldn't be accessed by user '_apt'. - pkgAcquire::Run (13: Permission denied)
6868
cp --verbose -- "${deb_file_original}" "${deb_file_copy}"
6969

70-
echo "$0: INFO: Dummy package created."
70+
printf '%s\n' "$0: INFO: Dummy package created."
7171
}
7272

7373
## Validate package name, see
7474
## https://www.debian.org/doc/debian-policy/ch-controlfields.html#source
7575
if ! grep --quiet '^[a-z0-9]\+[a-z0-9+-.]\+$' -- <<< "${package_to_replace}" ; then
76-
echo "$0: ERROR: Package name is invalid, check for typos" >&2
76+
printf '%s\n' "$0: ERROR: Package name is invalid, check for typos" >&2
7777
exit 1
7878
fi
7979

8080
## Not actually needed, mktemp can function perfectly well without TMPDIR
8181
# if [ -z "${TMPDIR:-}" ]; then
82-
# echo "$0: ERROR: TMPDIR is unset." >&2
82+
# printf '%s\n' "$0: ERROR: TMPDIR is unset." >&2
8383
# exit 1
8484
# fi
8585

@@ -103,15 +103,15 @@ Description: dummy-package for '${package_to_replace}'
103103
deb_file_copy="/var/lib/dummy-dependency/dummy-${package_to_replace}_99_all.deb"
104104

105105
if [ "${cached_option}" = "true" ]; then
106-
echo "$0: INFO: '--cached' option detected: yes"
106+
printf '%s\n' "$0: INFO: '--cached' option detected: yes"
107107
if test -e "${deb_file_copy}" ; then
108-
echo "$0: INFO: Using already existing cached dummy replacement package for '${package_to_replace}'..."
108+
printf '%s\n' "$0: INFO: Using already existing cached dummy replacement package for '${package_to_replace}'..."
109109
else
110-
echo "$0: INFO: Cached dummy replacement package for '${package_to_replace}' does not exist yet, creating..."
110+
printf '%s\n' "$0: INFO: Cached dummy replacement package for '${package_to_replace}' does not exist yet, creating..."
111111
create_dummy_dependency
112112
fi
113113
else
114-
echo "$0: INFO: Creating dummy replacement package for '${package_to_replace}'..."
114+
printf '%s\n' "$0: INFO: Creating dummy replacement package for '${package_to_replace}'..."
115115
create_dummy_dependency
116116
fi
117117

@@ -121,40 +121,40 @@ Description: dummy-package for '${package_to_replace}'
121121
## Sanity test.
122122
test -r "${deb_file_copy}"
123123

124-
echo "$0: INFO: Installing dummy package..."
124+
printf '%s\n' "$0: INFO: Installing dummy package..."
125125

126126
#lintian --pedantic --info --display-info "${deb_file_copy}"
127127

128-
echo "$0: Executing: apt-get $yes_option install -- ${deb_file_copy}"
128+
printf '%s\n' "$0: Executing: apt-get $yes_option install -- ${deb_file_copy}"
129129
if apt-get $yes_option install -- "${deb_file_copy}" ; then
130-
echo "$0: INFO: Dummy package installed."
130+
printf '%s\n' "$0: INFO: Dummy package installed."
131131
else
132-
echo "$0: ERROR: 'apt-get install' command failed!" >&2
132+
printf '%s\n' "$0: ERROR: 'apt-get install' command failed!" >&2
133133
exit 1
134134
fi
135135

136-
echo "$0: INFO: Removing package: '${package_to_replace}'"
136+
printf '%s\n' "$0: INFO: Removing package: '${package_to_replace}'"
137137
if [ "${remove_option}" = '--remove' ]; then
138-
echo "$0: INFO: Not purging old package configuration files... (Because not using '--purge'.)"
139-
echo "$0: INFO: Executing: apt-get $yes_option remove -- ${package_to_replace}"
138+
printf '%s\n' "$0: INFO: Not purging old package configuration files... (Because not using '--purge'.)"
139+
printf '%s\n' "$0: INFO: Executing: apt-get $yes_option remove -- ${package_to_replace}"
140140
if apt-get $yes_option remove -- ${package_to_replace} ; then
141-
echo "$0: INFO: Package removed."
141+
printf '%s\n' "$0: INFO: Package removed."
142142
else
143-
echo "$0: ERROR: 'apt-get remove' command failed!" >&2
143+
printf '%s\n' "$0: ERROR: 'apt-get remove' command failed!" >&2
144144
fi
145145
elif [ "${remove_option}" = '--purge' ]; then
146-
echo "$0: INFO: Purging old package configuration files..."
147-
echo "$0: INFO: Executing: apt-get $yes_option purge -- ${package_to_replace}"
146+
printf '%s\n' "$0: INFO: Purging old package configuration files..."
147+
printf '%s\n' "$0: INFO: Executing: apt-get $yes_option purge -- ${package_to_replace}"
148148
if apt-get $yes_option purge -- ${package_to_replace} ; then
149-
echo "$0: INFO: Package purged."
149+
printf '%s\n' "$0: INFO: Package purged."
150150
else
151-
echo "$0: ERROR: 'apt-get purge' command failed!" >&2
151+
printf '%s\n' "$0: ERROR: 'apt-get purge' command failed!" >&2
152152
fi
153153
fi
154154

155155
cleanup
156156
trap '' EXIT
157-
echo "$0: INFO: Done."
157+
printf '%s\n' "$0: INFO: Done."
158158
exit 0
159159
}
160160

0 commit comments

Comments
 (0)