Skip to content

Commit 27b8343

Browse files
github-actions[bot]rainestpmalek
authored
[Backport release/2.11.x] fix: disable Kong(Cluster)Plugin Programmed status (#4585)
* fix: disable Kong(Cluster)Plugin Programmed status (#4584) * fix(crds) disable KongPlugin programmed condition Disable the Kong(Cluster)Plugin programmed condition. This caused a bug in multi-class environments. Add a TODO explaining the issue. * chore(*) make generate * chore(doc): add changelog entry for 2.11.1 --------- Co-authored-by: Patryk Małek <patryk.malek@konghq.com> (cherry picked from commit 2bafc2d) * chore: trigger CI --------- Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com> Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
1 parent db0ad91 commit 27b8343

File tree

4 files changed

+176
-219
lines changed

4 files changed

+176
-219
lines changed

hack/generators/controllers/networking/main.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ var inputControllersNeeded = &typesNeeded{
114114
Plural: "kongplugins",
115115
CacheType: "Plugin",
116116
NeedsStatusPermissions: true,
117-
ConfigStatusNotificationsEnabled: true,
118-
ProgrammedConditionUpdatesEnabled: true,
117+
ConfigStatusNotificationsEnabled: false, // TODO true after https://github.com/Kong/kubernetes-ingress-controller/issues/4578
118+
ProgrammedConditionUpdatesEnabled: false, // TODO true after https://github.com/Kong/kubernetes-ingress-controller/issues/4578
119119
AcceptsIngressClassNameAnnotation: false,
120120
AcceptsIngressClassNameSpec: false,
121121
NeedsUpdateReferences: true,
@@ -131,8 +131,8 @@ var inputControllersNeeded = &typesNeeded{
131131
Plural: "kongclusterplugins",
132132
CacheType: "ClusterPlugin",
133133
NeedsStatusPermissions: true,
134-
ConfigStatusNotificationsEnabled: true,
135-
ProgrammedConditionUpdatesEnabled: true,
134+
ConfigStatusNotificationsEnabled: false, // TODO true after https://github.com/Kong/kubernetes-ingress-controller/issues/4578
135+
ProgrammedConditionUpdatesEnabled: false, // TODO true after https://github.com/Kong/kubernetes-ingress-controller/issues/4578
136136
AcceptsIngressClassNameAnnotation: true,
137137
AcceptsIngressClassNameSpec: false,
138138
NeedsUpdateReferences: true,

internal/controllers/configuration/zz_generated_controllers.go

Lines changed: 0 additions & 50 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/manager/controllerdef.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,8 @@ func setupControllers(
250250
DataplaneClient: dataplaneClient,
251251
CacheSyncTimeout: c.CacheSyncTimeout,
252252
ReferenceIndexers: referenceIndexers,
253-
StatusQueue: kubernetesStatusQueue,
253+
// TODO https://github.com/Kong/kubernetes-ingress-controller/issues/4578
254+
// StatusQueue: kubernetesStatusQueue,
254255
},
255256
},
256257
{
@@ -313,7 +314,8 @@ func setupControllers(
313314
DisableIngressClassLookups: !c.IngressClassNetV1Enabled,
314315
CacheSyncTimeout: c.CacheSyncTimeout,
315316
ReferenceIndexers: referenceIndexers,
316-
StatusQueue: kubernetesStatusQueue,
317+
// TODO https://github.com/Kong/kubernetes-ingress-controller/issues/4578
318+
// StatusQueue: kubernetesStatusQueue,
317319
},
318320
},
319321
// ---------------------------------------------------------------------------

0 commit comments

Comments
 (0)