From 974c058777b6c61fdf8b1a5e9c7f23ad3e4d8b32 Mon Sep 17 00:00:00 2001 From: lonevox Date: Mon, 27 Oct 2025 23:17:45 +1300 Subject: [PATCH] Remove remapping of Entity.hurt `Entity` already has a method called `attack`, which is used when the entity attacks something. `hurt` is used to damage the entity it is called on, so they have different usages, which makes it confusing that they have the same name in kjs. --- .../java/dev/latvian/mods/kubejs/core/mixin/EntityMixin.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/main/java/dev/latvian/mods/kubejs/core/mixin/EntityMixin.java b/src/main/java/dev/latvian/mods/kubejs/core/mixin/EntityMixin.java index cb02e108c..d367467d3 100644 --- a/src/main/java/dev/latvian/mods/kubejs/core/mixin/EntityMixin.java +++ b/src/main/java/dev/latvian/mods/kubejs/core/mixin/EntityMixin.java @@ -142,10 +142,6 @@ private void loadKJS(CompoundTag tag, CallbackInfo ci) { @RemapForJS("extinguish") public abstract void clearFire(); - @Shadow - @RemapForJS("attack") - public abstract boolean hurt(DamageSource source, float hp); - @Shadow @RemapForJS("getDistanceSq") public abstract double distanceToSqr(double x, double y, double z);