Skip to content

Commit c0053fb

Browse files
authored
Merge pull request #14 from LFDT-Lockness/dt
Remove slip10-like derivation and add stark-specific derivation
2 parents 980c062 + 158b65c commit c0053fb

File tree

14 files changed

+1113
-310
lines changed

14 files changed

+1113
-310
lines changed

.github/workflows/rust.yml

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,24 +9,41 @@ env:
99
CARGO_NET_GIT_FETCH_WITH_CLI: true
1010

1111
jobs:
12-
build-no-features:
12+
check-no-features:
1313
runs-on: ubuntu-latest
1414
steps:
1515
- uses: actions/checkout@v3
1616
- uses: Swatinem/rust-cache@v2
1717
with:
1818
cache-on-failure: "true"
1919
- name: Build
20-
run: cargo build
21-
build-and-test-all-features:
20+
run: cargo check --no-default-features
21+
check:
2222
runs-on: ubuntu-latest
23+
strategy:
24+
matrix:
25+
features:
26+
- slip10
27+
- slip10,curve-secp256k1
28+
- slip10,curve-secp256r1
29+
- edwards
30+
- stark
2331
steps:
2432
- uses: actions/checkout@v3
2533
- uses: Swatinem/rust-cache@v2
2634
with:
2735
cache-on-failure: "true"
2836
- name: Build
29-
run: cargo build --all-features
37+
run: cargo check --features ${{ matrix.features }}
38+
check-and-test-all-features:
39+
runs-on: ubuntu-latest
40+
steps:
41+
- uses: actions/checkout@v3
42+
- uses: Swatinem/rust-cache@v2
43+
with:
44+
cache-on-failure: "true"
45+
- name: Build
46+
run: cargo check --all-features
3047
- name: Run tests
3148
run: cargo test --all-features --lib --tests
3249
doctest:

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# hd-wallet crate changelog
22

3+
## v0.6.0
4+
* Remove slip10-like derivation that can be instantiated with any curve: it is very inefficient
5+
when instantiated with certain curves, and may also enable attacker to perform DoS attack by
6+
finding derivation path that results into very long computation [#14]
7+
* Add stark-specific derivation: secure and efficient derivation for stark curve [#14]
8+
9+
[#14]: https://github.com/LFDT-Lockness/hd-wallet/pull/14
10+
311
## v0.5.1
412
* Update docs and repo link [#11]
513

Cargo.lock

Lines changed: 171 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)