Hotfix performance issues due to a bad Mixin.

Author: LambdAurora

CHANGELOG.md

@@ -320,6 +320,10 @@
 - Added missing Spanish Mexican translations from Spanish translations as a stop-gap.
 - Updated German translations (thanks zOnlyKroks).
 
+### 4.2.3
+
+- Hotfix performance issues due to a wrong Mixin injection.
+
 [SpruceUI]: https://github.com/LambdAurora/SpruceUI "SpruceUI page"
 [pridelib]: https://github.com/Queerbric/pridelib "Pridelib page"
 [Sodium]: https://modrinth.com/mod/sodium "Sodium Modrinth page"

README.md

@@ -87,6 +87,12 @@ Wait... what? **Lasers?!** They do pack a punch...
 
 ![light levels](assets/guardian_laser.png)
 
+### Fireflies
+
+Fireflies particle will emit light as they fly!
+
+![Fireflies](assets/fireflies.png)
+
 ### Configuration GUI
 
 As of v4.0.0.

assets/fireflies.png

@@ -8,7 +8,7 @@ object Constants {
 	const val NAME = "lambdynamiclights"
 	const val NAMESPACE = "lambdynlights"
 	const val PRETTY_NAME = "LambDynamicLights"
-	const val VERSION = "4.2.2"
+	const val VERSION = "4.2.3"
 	const val JAVA_VERSION = 21
 
 	const val DESCRIPTION = "The most feature-complete dynamic lighting mod for Fabric."

build_logic/src/main/kotlin/lambdynamiclights/Constants.kt

@@ -7,7 +7,7 @@ object Utils {
 	fun parseReadme(project: Project): String {
 		return ModUtils.parseReadme(
 			project,
-			"https://raw.githubusercontent.com/LambdAurora/LambDynamicLights/1.21.4/\$2"
+			"https://raw.githubusercontent.com/LambdAurora/LambDynamicLights/1.21.5/\$2"
 		)
 	}
 

build_logic/src/main/kotlin/lambdynamiclights/Utils.kt

@@ -9,7 +9,7 @@
 
 package dev.lambdaurora.lambdynlights;
 
-import dev.lambdaurora.lambdynlights.accessor.WorldRendererAccessor;
+import dev.lambdaurora.lambdynlights.mixin.LevelRendererAccessor;
 import dev.lambdaurora.lambdynlights.api.DynamicLightsContext;
 import dev.lambdaurora.lambdynlights.api.DynamicLightsInitializer;
 import dev.lambdaurora.lambdynlights.api.behavior.DynamicLightBehavior;
@@ -478,7 +478,7 @@ private void scheduleChunkRebuild(@NotNull LevelRenderer renderer, long chunkPos
 
 	public static void scheduleChunkRebuild(@NotNull LevelRenderer renderer, int x, int y, int z) {
 		if (Minecraft.getInstance().level != null)
-			((WorldRendererAccessor) renderer).lambdynlights$scheduleChunkRebuild(x, y, z, false);
+			((LevelRendererAccessor) renderer).lambdynlights$scheduleChunkRebuild(x, y, z, false);
 	}
 
 	/**

src/main/java/dev/lambdaurora/lambdynlights/LambDynLights.java

@@ -1,5 +1,5 @@
 /*
- * Copyright © 2020 LambdAurora <email@lambdaurora.dev>
+ * Copyright © 2025 LambdAurora <email@lambdaurora.dev>
  *
  * This file is part of LambDynamicLights.
  *
@@ -10,30 +10,32 @@
 package dev.lambdaurora.lambdynlights.mixin;
 
 import dev.lambdaurora.lambdynlights.LambDynLights;
-import dev.lambdaurora.lambdynlights.accessor.WorldRendererAccessor;
 import net.minecraft.client.renderer.LevelRenderer;
 import net.minecraft.core.BlockPos;
 import net.minecraft.world.level.BlockAndTintGetter;
-import net.minecraft.world.level.block.state.BlockState;
 import org.spongepowered.asm.mixin.Mixin;
-import org.spongepowered.asm.mixin.gen.Invoker;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Inject;
 import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
 
-@Mixin(value = LevelRenderer.class, priority = 900)
-public abstract class CommonLevelRendererMixin implements WorldRendererAccessor {
-	@Invoker("setSectionDirty")
-	@Override
-	public abstract void lambdynlights$scheduleChunkRebuild(int x, int y, int z, boolean important);
-
+/**
+ * Injects the dynamic lighting into the default brightness getter.
+ * <p>
+ * Injecting into the default brightness getter allows to benefit from brightness caching in the Vanilla renderer.
+ *
+ * @author LambdAurora
+ * @version 4.2.3
+ * @since 4.2.3
+ */
+@Mixin(value = LevelRenderer.BrightnessGetter.class, priority = 900)
+public interface BrightnessGetterMixin {
 	@Inject(
-			method = "getLightColor(Lnet/minecraft/client/renderer/LevelRenderer$BrightnessGetter;Lnet/minecraft/world/level/BlockAndTintGetter;Lnet/minecraft/world/level/block/state/BlockState;Lnet/minecraft/core/BlockPos;)I",
+			method = "method_68890",
 			at = @At("TAIL"),
 			cancellable = true
 	)
 	private static void onGetLightmapCoordinates(
-			LevelRenderer.BrightnessGetter getter, BlockAndTintGetter level, BlockState state, BlockPos pos,
+			BlockAndTintGetter level, BlockPos pos,
 			CallbackInfoReturnable<Integer> cir
 	) {
 		if (!level.getBlockState(pos).isSolidRender() && LambDynLights.get().config.getDynamicLightsMode().isEnabled())

src/main/java/dev/lambdaurora/lambdynlights/mixin/CommonLevelRendererMixin.java renamed to src/main/java/dev/lambdaurora/lambdynlights/mixin/BrightnessGetterMixin.java

@@ -7,16 +7,21 @@
  * see the LICENSE file.
  */
 
-package dev.lambdaurora.lambdynlights.accessor;
+package dev.lambdaurora.lambdynlights.mixin;
+
+import net.minecraft.client.renderer.LevelRenderer;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.gen.Invoker;
 
 /**
  * Represents an accessor for WorldRenderer.
  *
  * @author LambdAurora
- * @version 1.0.0
+ * @version 4.2.3
  * @since 1.0.0
  */
-public interface WorldRendererAccessor {
+@Mixin(LevelRenderer.class)
+public interface LevelRendererAccessor {
 	/**
 	 * Schedules a chunk rebuild.
 	 *
@@ -25,5 +30,6 @@ public interface WorldRendererAccessor {
 	 * @param z Z coordinates of the chunk
 	 * @param important {@code true} if important, else {@code false}
 	 */
+	@Invoker("setSectionDirty")
 	void lambdynlights$scheduleChunkRebuild(int x, int y, int z, boolean important);
 }

src/main/java/dev/lambdaurora/lambdynlights/accessor/WorldRendererAccessor.java renamed to src/main/java/dev/lambdaurora/lambdynlights/mixin/LevelRendererAccessor.java

@@ -4,13 +4,14 @@
 	"plugin": "dev.lambdaurora.lambdynlights.LambDynLightsMixinPlugin",
 	"compatibilityLevel": "JAVA_21",
 	"client": [
+		"BrightnessGetterMixin",
 		"ClientLevelMixin",
-		"CommonLevelRendererMixin",
 		"DebugRendererMixin",
 		"DebugScreenOverlayMixin",
 		"DevModeMixin",
 		"EntityRendererMixin",
 		"EntityTypeMixin",
+		"LevelRendererAccessor",
 		"MinecraftClientMixin",
 		"VideoSettingsScreenMixin",
 		"fabric.AoCalculatorMixin",