[v7] Remove spatie HasTranslations trait overwrite to allow compatibility with packages like spatie/laravel-tags

[daxsis]

Bug report

Declaration of Backpack\CRUD\app\Models\Traits\SpatieTranslatable\HasTranslations::getLocale() must be compatible with Spatie\Tags\Tag::getLocale(): string

What I did

Install package from spatie/laravel-tags and use custom Tag model, which changes in the core functionality of the spatie package nothing.

What I expected to happen

No conflicts of the resolution between spatie/laravel-tags and backpack version of the HasTranlsation trait

What happened

??

What I've already tried to fix it

add return type ): string but then there is another issue which is

Declaration of Backpack\CRUD\app\Models\Traits\SpatieTranslatable\HasTranslations::setTranslation(string $key, string $locale, $value): Backpack\CRUD\app\Models\Traits\SpatieTranslatable\HasTranslations must be compatible with Spatie\Tags\Tag::setTranslation(string $key, string $locale, $value): Spatie\Tags\Tag

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

PHP VERSION:

PHP 7.4.3 (cli) (built: Feb 18 2020 17:29:46) ( ZTS Visual C++ 2017 x64 )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
with Xdebug v2.9.2, Copyright (c) 2002-2020, by Derick Rethans

LARAVEL VERSION:

v7.9.2@757b155658ae6da429065ba8f22242fe599824f7

BACKPACK VERSION:

4.0.60@3c6116bce3c90ef9850d3d07de5c7b8f41a7b6cd

[daxsis]

I tested with 4.1 of backpack. The same issue

[tabacitu]

Thanks for raising the issue @daxsis . Hmm... Then you should probably roll your own HasTranslation trait, instead of using the one provided by Backpack, that has the changes this needs. We won't be able to fix this for a while - I want Backpack to be compatible with Spatie/Laravel-Tags, but right now we're working on launching 4.1 and I'm afraid this issue won't be a priority for us for some time - so I recommend you go for a solution yourself.

Providing a solution in Backpack won't be as easy as creating a solution inside your project - I bet spatie requires PHP 7.4 whereas Backpack support PHP down to 7.2.5 - so our solutions have to take that into consideration.

Sorry to be the bearer of bad news! If you end up with a solution you like, please consider sharing it here, or as a PR - it would be much appreciated and it would go a long way towards having a fix inside Backpack.

[stephenr85]

This is still an issue. The last compatible version of Translatable package is https://github.com/spatie/laravel-translatable/releases/tag/4.6.0 (from 2020).

After creating my own trait with compatible methods and following the docs, including having the appropriate fields in $translatable, the fields still showed as arrays in the CRUD form. With the field types set to "text" or "slug", the resulting values were empty. This might be due to even more of the HasTranslation trait needing to be updated, but this indicates to me that it's not a safe feature to use at the moment, unfortunately.