0.19.12-beta.4 was build with debug profile

[Nutomic]

Relevant build log

For comparison 0.19.11

For some reason the parameter RUST_RELEASE_MODE=release was not passed properly, instead it was set to *=RUST_RELEASE_MODE=release (log for 0.19.12-beta.4, log for 0.19.11).

I noticed this because a debug assertion was triggered on lemmy.ml. It can also be seen that all Docker images starting from 0.19.12-beta.0 have a size of 92 mb, compared to 69 mb for previous versions.

For now I built a release image locally and uploaded it directly to lemmy.ml. Not sure what caused this problem or how to fix it, as there were no changes to that part of .woodpecker.yml. There was a new version 6.0 for woodpeckerci/plugin-docker-buildx but the changelog doesnt mention anything relevant.

Edit: Change is described in this issue, lets see if that works (ci link).

[Nothing4You]

the issue you linked indicates that this was changed from a list to a mapping. odd that that wouldn't be mentioned in the release notes.
you seem to not have included the woodpecker change in the latest tag though.

[Nutomic]

The fix is here: deca323

But its still passing the build arg wrong: https://woodpecker.join-lemmy.org/repos/129/pipeline/14002/5#L102

[Nothing4You]

https://codeberg.org/woodpecker-plugins/docker-buildx/pulls/229

BREAKING CHANGES:

cache_from is now a list instead of a string
args is now an object instead of a string

that should probably have been part of the release notes directly.

the correct change would be changing

      build_args:
        - RUST_RELEASE_MODE=release

to

      build_args:
        RUST_RELEASE_MODE: release

in both places where this is used.

[Nutomic]

Ah right its used twice, fixed now.

[Nothing4You]

even if it does work, it probably should still use a mapping rather than just a string, as the mapping is the documented way to use it: https://codeberg.org/woodpecker-plugins/docker-buildx/src/branch/main/docs.md#examples

[Nutomic]

Right it was still failing, now I got it.

https://woodpecker.join-lemmy.org/repos/129/pipeline/14010/5#L102

[Nutomic]

Yep looks fine now, docker image is back down to 69mb and working on lemmy.ml without problems.