Fixed race condition when exiting Application on macOS

Signed-off-by: Loren Eteval <loren.eteval@proton.me>

Author: LorenEteval

Furious/Widget/Application.py

@@ -188,6 +188,7 @@ def __init__(self, argv):
 
         # ThreadPool
         self.threadPool = QtCore.QThreadPool()
+        self.threadPool.setMaxThreadCount(max(OS_CPU_COUNT // 2, 1))
 
     @rateLimited(maxCallPerSecond=2)
     @QtCore.Slot()
@@ -283,6 +284,10 @@ def cleanup():
             SystemProxy.off()
             SystemProxy.daemonOff()
 
+        AppThreadPool().clear()
+
+        APP().processEvents()
+
         logger.info('final cleanup done')
 
     @staticmethod

Furious/Widget/UserServersQTableWidget.py

@@ -1568,8 +1568,15 @@ def testSelectedItemPingLatency(self):
         references = list(AS_UserServers()[index] for index in indexes)
 
         for index, reference in zip(indexes, references):
-            worker = TestPingLatencyWorker(reference)
+            if APP().isExiting():
+                break
+
+            assert isinstance(reference, ConfigurationFactory)
 
+            if reference.deleted:
+                continue
+
+            worker = TestPingLatencyWorker(reference)
             worker.setAutoDelete(True)
             worker.finished.connect(
                 functools.partial(
@@ -1593,8 +1600,15 @@ def testSelectedItemTcpingLatency(self):
         references = list(AS_UserServers()[index] for index in indexes)
 
         for index, reference in zip(indexes, references):
-            worker = TestTcpingLatencyWorker(reference)
+            if APP().isExiting():
+                break
+
+            assert isinstance(reference, ConfigurationFactory)
+
+            if reference.deleted:
+                continue
 
+            worker = TestTcpingLatencyWorker(reference)
             worker.setAutoDelete(True)
             worker.finished.connect(
                 functools.partial(
@@ -1660,10 +1674,15 @@ def handleTestDownloadSpeedJobXXX(
         jobTimer: QtCore.QTimer,
         isMulti: bool,
     ):
-        try:
-            if isMulti and not self.testDownloadSpeedMultiSema.tryAcquire(1):
-                return
+        if APP().isExiting():
+            jobTimer.stop()
+
+            return
 
+        if isMulti and not self.testDownloadSpeedMultiSema.tryAcquire(1):
+            return
+
+        try:
             index, factory, timeout = jobQueue.get_nowait()
         except queue.Empty:
             # Queue is empty
@@ -1686,7 +1705,9 @@ def handleTestDownloadSpeedJobXXX(
 
                 if not APP().isExiting():
                     # Fetch next job.
-                    jobTimer.start(1)
+                    jobTimer.start(5)
+                else:
+                    jobTimer.stop()
             else:
                 testDownloadSpeedPort = 20809
 
@@ -1699,19 +1720,23 @@ def handleTestDownloadSpeedJobXXX(
 
             if not APP().isExiting():
                 # Fetch next job.
-                jobTimer.start(1)
+                jobTimer.start(5)
+            else:
+                jobTimer.stop()
         else:
-            self.testDownloadSpeedByFactory(
-                index,
-                factory,
-                testDownloadSpeedPort,
-                timeout,
-                isMulti,
-            )
-
             if not APP().isExiting():
+                self.testDownloadSpeedByFactory(
+                    index,
+                    factory,
+                    testDownloadSpeedPort,
+                    timeout,
+                    isMulti,
+                )
+
                 # Fetch next job.
-                jobTimer.start(1)
+                jobTimer.start(5)
+            else:
+                jobTimer.stop()
 
     @QtCore.Slot()
     def handleTestDownloadSpeedJob(self):